Initial config for TypeScript refactor #518
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). |
Codecov Report
|
| @@ -0,0 +1,65 @@ | |||
| { | |||
| "compilerOptions": { | |||
There was a problem hiding this comment.
Note: when we ship this, we can remove jsconfig.json (see #520) and merge its config into this file.
connor-baer
changed the title
connor-baer
changed the title
| } | ||
|
|
||
| interface Props { | ||
| size: SIZE_PROP_TYPE // Size of the button. Use the Button's KILO, MEGA, or GIGA properties. |
There was a problem hiding this comment.
The comments need to remain this format so they can be picked up by react-docgen.
| size: SIZE_PROP_TYPE // Size of the button. Use the Button's KILO, MEGA, or GIGA properties. | |
| /** | |
| * Size of the button. Use the Button's KILO, MEGA, or GIGA properties. | |
| */ | |
| size: SIZE_PROP_TYPE |
| primary: boolean // Renders a primary button using the brand color. | ||
| disabled: boolean // Should the Button be disabled? | ||
| secondary: boolean // Renders a secondary button. Secondary buttons look the same for primary (default) and flat buttons. | ||
| defaultProps: {} |
| Button.KILO = KILO; | ||
| Button.MEGA = MEGA; | ||
| Button.GIGA = GIGA; |
There was a problem hiding this comment.
Do you know how to type static properties on a function? I couldn't find anything when I googled it 🤔
| @@ -0,0 +1,65 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "noEmit": true, | |||
There was a problem hiding this comment.
We want to use TypeScript as our compiler, not just for type checking.
| /* Basic Options */ | ||
| // "incremental": true, /* Enable incremental compilation */ | ||
| "target": "es5", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */ | ||
| "module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ |
There was a problem hiding this comment.
This needs to be es2015 or higher, otherwise, tree-shaking won't work.
| "noEmit": true, | ||
| /* Basic Options */ | ||
| // "incremental": true, /* Enable incremental compilation */ | ||
| "target": "es5", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */ |
There was a problem hiding this comment.
We want to publish modern code so the user can decide if they need to transpile the code. Next.js and CRA now transpile node modules, and Next.js even provides modern bundles for newer browsers.
|
Closing in favor of #563. |
Addresses #516
Purpose
Approach and changes
Definition of done