Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(configs): configure TypeScript build system #563

Merged
merged 10 commits into from
Apr 15, 2020
Merged

feat(configs): configure TypeScript build system #563

merged 10 commits into from
Apr 15, 2020

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Apr 6, 2020 •
edited
Loading

Addresses #516.

Purpose

We plan to gradually migrate Circuit UI to TypeScript. The first step is to replace Babel with TypeScript as the compiler. This is a potentially breaking change, so we need to do it in v2.

Approach and changes

  • Install and configure TypeScript
  • Configure all tooling to work with TypeScript: Eslint, Jest, Storybook
  • Add basic types, including one for the Emotion theme

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added this to the v2.0 milestone Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020 •
edited
Loading

Codecov Report

Merging #563 into alpha will decrease coverage by 0.63%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            alpha     #563      +/-   ##
==========================================
- Coverage   93.15%   92.51%   -0.64%     
==========================================
  Files         155      223      +68     
  Lines        2468     3021     +553     
  Branches      686      710      +24     
==========================================
+ Hits         2299     2795     +496     
- Misses        138      191      +53     
- Partials       31       35       +4
Impacted Files Coverage Δ
src/styles/style-helpers.js 98.52% <100.00%> (ø)
src/util/regex.js 100.00% <100.00%> (ø)
...nents/AutoCompleteInput/AutoCompleteInput.story.js 100.00% <0.00%> (ø)
...nts/CalendarTagTwoStep/CalendarTagTwoStep.story.js 100.00% <0.00%> (ø)
src/components/Row/Row.story.js 100.00% <0.00%> (ø)
src/components/Step/Step.story.js 100.00% <0.00%> (ø)
...s/SimpleCurrencyInput/SimpleCurrencyInput.story.js 100.00% <0.00%> (ø)
src/components/Heading/Heading.story.js 100.00% <0.00%> (ø)
src/components/Button/Button.story.js 100.00% <0.00%> (ø)
...ponents/Carousel/components/Status/Status.story.js 100.00% <0.00%> (ø)
... and 60 more

@vercel
Copy link

vercel bot commented Apr 6, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/sumup-oss/circuit-ui/e7f59yixj
✅ Preview: https://circuit-ui-git-chore-typescript.sumup-oss.now.sh

@connor-baer connor-baer mentioned this pull request Apr 12, 2020
Merged
@fernandofleury fernandofleury requested review from fernandofleury and removed request for nikilok April 15, 2020 08:26
fernandofleury
fernandofleury approved these changes Apr 15, 2020
View reviewed changes
src/types/theme.ts
lineHeight: string;
};

export interface Theme {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can still break these by groups and use Merge if you like.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Merge a utility type? I couldn't find any documentation for it.

src/util/regex.js
@@ -13,9 +13,11 @@
* limitations under the License.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are a bit scary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint suggested these changes. They look safe to me.

@connor-baer connor-baer added the 🛠️ tech Changes to the tech stack or infrastructure label Apr 15, 2020
@connor-baer connor-baer merged commit db9d865 into alpha Apr 15, 2020
@connor-baer connor-baer deleted the chore/typescript branch April 15, 2020 10:24
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0-alpha.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@connor-baer connor-baer mentioned this pull request Apr 20, 2020
Closed
5 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2020

🎉 This PR is included in version 2.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fernandofleury fernandofleury fernandofleury approved these changes

@marielakas marielakas Awaiting requested review from marielakas

@hleote hleote Awaiting requested review from hleote

Assignees
No one assigned
Labels
🛠️ tech Changes to the tech stack or infrastructure
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@connor-baer @fernandofleury @hleote