Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] dev mode refactor #3138

Merged
merged 15 commits into from
Dec 31, 2021
Merged

[chore] dev mode refactor #3138

merged 15 commits into from
Dec 31, 2021

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Dec 30, 2021

WIP. follow-up to #3129. Using Vite's watcher means we can push more logic into the plugin. Also, Watcher extends EventEmitter but we're not actually emitting any events, so we can make all that stuff way simpler

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2021

⚠️ No Changeset found

Latest commit: a802fc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member Author

This will fix #2793

@Rich-Harris
Copy link
Member Author

Bit weirded out by these deployment failures. Investigating

@Rich-Harris
Copy link
Member Author

deploys all passing — issue turned out to be netlify being a bit overzealous with the build cache

@benmccann benmccann changed the title Dev mode refactor 2 [chore] dev mode refactor Dec 31, 2021
@Rich-Harris Rich-Harris merged commit 42fac84 into master Dec 31, 2021
@Rich-Harris Rich-Harris deleted the dev-mode-refactor-2 branch December 31, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to use polling instead of filesystem events when watching for filesystem changes
2 participants