Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] dev mode refactor #3138

Merged
merged 15 commits into from
Dec 31, 2021
Merged

[chore] dev mode refactor #3138

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0fccd83
use vite.watcher instead of cheap-watch
Rich-Harris Dec 30, 2021
94fab5c
remove some indirection
Rich-Harris Dec 30, 2021
452985a
remove some more indirection
Rich-Harris Dec 30, 2021
ce0f01f
more simplifying
Rich-Harris Dec 30, 2021
aa1978d
simplify
Rich-Harris Dec 30, 2021
4968348
lint
Rich-Harris Dec 30, 2021
06f51b0
remove code that apparently doesnt do anything
Rich-Harris Dec 30, 2021
5c481cc
apparently no longer necessary
Rich-Harris Dec 30, 2021
202bbb5
typecheck
Rich-Harris Dec 30, 2021
90deae4
tests passing
Rich-Harris Dec 30, 2021
7833faf
move plugin into separate module
Rich-Harris Dec 30, 2021
aa438d3
remove cheap-watch
Rich-Harris Dec 30, 2021
f962860
update lockfile
Rich-Harris Dec 30, 2021
969704d
revert versions in create-svelte
Rich-Harris Dec 30, 2021
a802fc7
Merge branch 'master' into dev-mode-refactor-2
Rich-Harris Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more simplifying
  • Loading branch information
@Rich-Harris
Rich-Harris committed Dec 30, 2021
commit ce0f01f65f452319ca6a6958c43bb158cfcb9dc1
9 changes: 1 addition & 8 deletions packages/kit/src/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,17 +93,10 @@ prog
try {
const watcher = await dev({ port, host, https, config });

watcher.on('stdout', (data) => {
process.stdout.write(data);
});

watcher.on('stderr', (data) => {
process.stderr.write(data);
});

if (!watcher.vite || !watcher.vite.httpServer) {
throw Error('Could not find server');
}

// we never start the server on a socket path, so address will be of type AddressInfo
const address_info = /** @type {import('net').AddressInfo} */ (
watcher.vite.httpServer.address()
Expand Down
Loading