[Concurrency] TaskExecutor ownership fixes #74000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-taskexecutor-retain
branch
from
0837541
to
89a4eea
Compare
ktoso
commented
May 30, 2024
ktoso
commented
May 30, 2024
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-taskexecutor-retain
branch
from
89a4eea
to
1f3e536
Compare
ktoso
commented
Jun 3, 2024
ktoso
force-pushed
the
wip-taskexecutor-retain
branch
4 times, most recently
from
cdadf00
to
707551e
Compare
ktoso
commented
Jun 5, 2024
ktoso
force-pushed
the
wip-taskexecutor-retain
branch
from
707551e
to
66cee59
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test |
DougGregor
reviewed
Jun 7, 2024
ktoso
force-pushed
the
wip-taskexecutor-retain
branch
from
60be029
to
c310d08
Compare
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-taskexecutor-retain
branch
2 times, most recently
from
3c74d42
to
ac3d8a8
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
ktoso
changed the title
As only owned task executors must be released during the tasks deinit afterwards fix builtins test
creating tasks with new builtin defaulted "owned" task executor parameter.
|
@swift-ci please smoke test macOS |
ktoso
force-pushed
the
wip-taskexecutor-retain
branch
from
e384026
to
8e66493
Compare
|
@swift-ci please smoke test |
This resolves linking issues on embedded platforms
|
Again not sure why embedded didn't fail here, it's supposed to run in smoke tests I thought. Anyway, resolved and that's the last issue here 🥳 |
|
@swift-ci please smoke test |
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Jun 20, 2024
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be retaining the task executor as we take it into the Task.
Resolves rdar://128943372