Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Concurrency] TaskExecutor ownership fixes #74000

Merged
merged 10 commits into from
Jun 14, 2024
Merged

[Concurrency] TaskExecutor ownership fixes #74000

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
42cc8e9
Implemented consuming builtin; fixes async_task_executor_unstructured…
ktoso Jun 3, 2024
acb6099
TaskGroup.addTask now also retains the task executor
ktoso Jun 5, 2024
6de4366
[Concurrency] initial task ex preference must store if it is owned
ktoso Jun 6, 2024
594a701
fix types in IRGen test; existential TaskExecutor
ktoso Jun 7, 2024
bf18490
Survive using SDK which does not have TaskExecutor declared when
ktoso Jun 7, 2024
e75866f
Further hardening against missing TaskExecutor type
ktoso Jun 10, 2024
19809e7
Lesson boilerplate in binary compatibility handling code in builtins
ktoso Jun 10, 2024
8e66493
undo accidental removal of codesigning in test
ktoso Jun 13, 2024
9ac80fa
un-comment some test coverage
ktoso Jun 14, 2024
6962c7e
[Embedded] Owned TaskExecutor is not available in Embeddedl fix runtime
ktoso Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[Embedded] Owned TaskExecutor is not available in Embeddedl fix runtime 
This resolves linking issues on embedded platforms
  • Loading branch information
@ktoso
ktoso committed Jun 14, 2024
commit 6962c7e3d9af9e49987058461f9d1e9f918d70f8
4 changes: 4 additions & 0 deletions stdlib/public/Concurrency/Task.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,10 +693,14 @@ swift_task_create_commonImpl(size_t rawTaskCreateFlags,
break;

case TaskOptionRecordKind::InitialTaskExecutorOwned:
#if SWIFT_CONCURRENCY_EMBEDDED
swift_unreachable("owned TaskExecutor cannot be used in embedded Swift");
#else
taskExecutor = cast<InitialTaskExecutorOwnedPreferenceTaskOptionRecord>(option)
->getExecutorRefFromUnownedTaskExecutor();
taskExecutorIsOwned = true;
jobFlags.task_setHasInitialTaskExecutorPreference(true);
#endif
break;

case TaskOptionRecordKind::TaskGroup:
Expand Down