[CodeCompletion] Fix crash when completing in arguments of unresolved pattern inside closure #74083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pattern inside closure rdar://128661960
ahoppen
requested review from
bnbarham,
rintaro,
hamishknight,
hborla and
xedin
as code owners
|
@swift-ci Please smoke test |
hamishknight
reviewed
Jun 3, 2024
Comment on lines
+704
to
+705
| if (hasType(fnExpr)) { | ||
| if (auto *loc = getSpecialFnCalleeLoc(getType(fnExpr))) { |
There was a problem hiding this comment.
This doesn't seem right, getType is a function being passed into getCalleeLocator whereas hasType is the ConstraintSystem member; you'd need to plumb through a separate hasType function. That being said I'm curious why the type wouldn't be set here 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://128661960