[Sema] Requestify pattern resolution #74387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a cached request to perform pattern resolution. This is needed to prevent the constraint system from resolving the same pattern multiple times along different solver paths, which could result in creating different pattern nodes for each path. Once pattern resolution is moved to pre-checking we ought to be able to make this uncached. rdar://128661960
hamishknight
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham and
rintaro
as code owners
|
@swift-ci please SourceKit stress test |
rintaro
approved these changes
Jun 17, 2024
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cached request to perform pattern resolution. This is needed to prevent the constraint system from resolving the same pattern multiple times along different solver paths, which could result in creating different pattern nodes for each path. Once pattern resolution is moved to pre-checking we ought to be able to make this uncached.
rdar://128661960