Improve the logic of "attemptsMade"

[manast]

Introduction

Currently "attemptsMade" is coupled to the retry mechanism, as it is only incremented when a retry has been issued. This is semantically awkward as in that this number does not really represent the number of times a job has been attempted to be processed, for example, a worker may die causing its current job to stall. This job will be picked up later by a worker and effectively-being processed a second time, but "attemptsMade" will still be 0.

Requirements

The "attemptsMade" field should be incremented when and only a job is moved to active. This will better reflect its semantical intent and also be more efficient with functions like "retry all failed jobs", which otherwise would require to update the "attemptsMade" field for every job, making it much more slower.

Since attemptsMade will now be 1 after the first time a job is processed, the retry logic must also take this change into account so that jobs are retried automatically at the max number specified in the "attempts" settings. Note that this change is not 100% backwards compatible, since an older job processed with a precious version of BullMQ will be retried 1 more time with the new code, but I do not think this slight change motivates a major version release, a minor would be OK IMHO.

[github-actions]

🎉 This issue has been resolved in version 1.66.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀