-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(job): increase attemptsMade when moving job to active #1009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
tests/test_worker.ts
Outdated
@@ -1560,7 +1560,7 @@ describe('workers', function () { | |||
await new Promise<void>(resolve => { | |||
worker.on('completed', () => { | |||
const elapse = Date.now() - start; | |||
expect(elapse).to.be.greaterThan(2000); | |||
expect(elapse).to.be.greaterThan(1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this reduction in time needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because, the first time is moved to active, attemptsMade is set as 1, before it was 0 the first time
🎉 This PR is included in version 1.66.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ref #1002