feat(queue-events): add retries-exhausted event #1010

roggervalf · 2022-01-20T01:33:30Z

No description provided.

# [1.65.0](v1.64.4...v1.65.0) (2022-01-21) ### Features * **queue:** add JobType and JobState unions for better typing ([#1011](#1011)) ([3b9b79d](3b9b79d))

## [1.65.1](v1.65.0...v1.65.1) (2022-01-21) ### Bug Fixes * dont loop through empty modules paths ([#1013](#1013)) fixes [#1012](#1012) ([86e84df](86e84df))

manast · 2022-01-22T05:00:32Z

src/commands/moveToFinished-8.lua

@@ -132,7 +132,7 @@ if rcall("EXISTS",jobIdKey) == 1 then -- // Make sure job exists
    rcall("XADD", KEYS[6], "*", "event", ARGV[5], "jobId", jobId, ARGV[3],
          ARGV[4])

-    if ARGV[15] then
+    if ARGV[15] > 0 then


So this will not happen if the job completed instead of failing right?

I'll verify it

manast · 2022-01-22T05:01:46Z

LGTM, although I guess we also need to update QueueEvents with the typings and documentation for this event.

manast · 2022-01-22T05:21:16Z

src/classes/scripts.ts

@@ -300,6 +300,9 @@ export class Scripts {
      target,
      token,
      fetchNext,
+      job.opts.attempts && job.attemptsMade >= job.opts.attempts


this will work mostly, but there would be more robust to do this check in the .lua script itself if possible. If it is awkward or hard we could postpone it, but good to have it documented.

roggervalf · 2022-01-22T05:26:18Z

LGTM, although I guess we also need to update QueueEvents with the typings and documentation for this event.

I added the event typing

manast

Lots of changes, but I guess they are not so many in practice so it will look better if doing a rebase.

roggervalf · 2022-01-23T04:15:20Z

Lots of changes, but I guess they are not so many in practice so it will look better if doing a rebase.

Oh, in reality because I did a rebase from master some of those commits are appearing here, we should be good with a squash, for some reason some of the changes that are already on master are appearing like new changes but they are not

# [1.66.0](v1.65.1...v1.66.0) (2022-01-23) ### Features * **queue-events:** add retries-exhausted event ([#1010](#1010)) ([e476f35](e476f35))

github-actions · 2022-01-23T04:20:01Z

🎉 This PR is included in version 1.66.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

roggervalf · 2022-01-23T04:20:11Z

e476f35 as reference the real changes

test(backoff): add case when attempts is 1

27b50b7

roggervalf requested a review from manast January 20, 2022 01:51

roggervalf and others added 3 commits January 20, 2022 19:17

feat(queue): add JobType and JobState unions for better typing (#1011)

3b9b79d

chore(release): 1.65.0 [skip ci]

7f0245d

# [1.65.0](v1.64.4...v1.65.0) (2022-01-21) ### Features * **queue:** add JobType and JobState unions for better typing ([#1011](#1011)) ([3b9b79d](3b9b79d))

feat(queue-events): add retries-exhausted event

78117d0

roggervalf changed the title ~~test(backoff): add case when attempts is 1~~ feat(queue-events): add retries-exhausted event Jan 21, 2022

roggervalf and others added 3 commits January 20, 2022 22:03

refactor: emit event only once

dc95c2d

fix: dont loop through empty modules paths (#1013) fixes #1012

86e84df

chore(release): 1.65.1 [skip ci]

3677295

## [1.65.1](v1.65.0...v1.65.1) (2022-01-21) ### Bug Fixes * dont loop through empty modules paths ([#1013](#1013)) fixes [#1012](#1012) ([86e84df](86e84df))

manast reviewed Jan 22, 2022

View reviewed changes

refactor(move-to-finished): check retriesExhausted before pass

6714cce

manast reviewed Jan 22, 2022

View reviewed changes

roggervalf added 9 commits January 22, 2022 13:32

fix(move-to-finished): emit retries-exhausted only in failed state

afb205c

test(backoff): add case when attempts is 1

72cecd7

feat(queue-events): add retries-exhausted event

3518d5f

refactor: emit event only once

4cfe1be

refactor(move-to-finished): check retriesExhausted before pass

b7d58a8

fix(move-to-finished): emit retries-exhausted only in failed state

6aeca87

refactor(move-to-finished): check attempts in lua script

23777cb

style: add finished target types

8b8315d

chore: merge conflicts

338a516

manast approved these changes Jan 23, 2022

View reviewed changes

roggervalf merged commit e476f35 into master Jan 23, 2022

roggervalf deleted the test-retry-1-case branch January 23, 2022 04:18

github-actions bot pushed a commit that referenced this pull request Jan 23, 2022

chore(release): 1.66.0 [skip ci]

9945a03

# [1.66.0](v1.65.1...v1.66.0) (2022-01-23) ### Features * **queue-events:** add retries-exhausted event ([#1010](#1010)) ([e476f35](e476f35))

github-actions bot added the released label Jan 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(queue-events): add retries-exhausted event #1010

feat(queue-events): add retries-exhausted event #1010

roggervalf commented Jan 20, 2022

manast Jan 22, 2022

roggervalf Jan 22, 2022

manast commented Jan 22, 2022 •

edited

Loading

manast Jan 22, 2022

roggervalf commented Jan 22, 2022

manast left a comment

roggervalf commented Jan 23, 2022

github-actions bot commented Jan 23, 2022

roggervalf commented Jan 23, 2022

feat(queue-events): add retries-exhausted event #1010

feat(queue-events): add retries-exhausted event #1010

Conversation

roggervalf commented Jan 20, 2022

manast Jan 22, 2022

Choose a reason for hiding this comment

roggervalf Jan 22, 2022

Choose a reason for hiding this comment

manast commented Jan 22, 2022 • edited Loading

manast Jan 22, 2022

Choose a reason for hiding this comment

roggervalf commented Jan 22, 2022

manast left a comment

Choose a reason for hiding this comment

roggervalf commented Jan 23, 2022

github-actions bot commented Jan 23, 2022

roggervalf commented Jan 23, 2022

manast commented Jan 22, 2022 •

edited

Loading