-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(queue-events): add retries-exhausted event #1010
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
27b50b7
test(backoff): add case when attempts is 1
roggervalf 3b9b79d
feat(queue): add JobType and JobState unions for better typing (#1011)
roggervalf 7f0245d
chore(release): 1.65.0 [skip ci]
semantic-release-bot 78117d0
feat(queue-events): add retries-exhausted event
roggervalf dc95c2d
refactor: emit event only once
roggervalf 86e84df
fix: dont loop through empty modules paths (#1013) fixes #1012
lukepolo 3677295
chore(release): 1.65.1 [skip ci]
semantic-release-bot 6714cce
refactor(move-to-finished): check retriesExhausted before pass
roggervalf afb205c
fix(move-to-finished): emit retries-exhausted only in failed state
roggervalf 72cecd7
test(backoff): add case when attempts is 1
roggervalf 3518d5f
feat(queue-events): add retries-exhausted event
roggervalf 4cfe1be
refactor: emit event only once
roggervalf b7d58a8
refactor(move-to-finished): check retriesExhausted before pass
roggervalf 6aeca87
fix(move-to-finished): emit retries-exhausted only in failed state
roggervalf 23777cb
refactor(move-to-finished): check attempts in lua script
roggervalf 8b8315d
style: add finished target types
roggervalf 338a516
chore: merge conflicts
roggervalf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will not happen if the job completed instead of failing right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll verify it