-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eager workflow dispatch #3835
Merged
Merged
Eager workflow dispatch #3835
Changes from 15 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ea6b281
Eager workflow dispatch
bergundy 5f23b7c
Revert returning workflowTaskInfo from NewWorkflowWithSignal
bergundy bb221c7
Fix lint issues
bergundy c3a4cd9
Minor restructuring
bergundy e8b8fba
Support eager start with TERMINATE_IF_RUNNING
bergundy fa4dccf
Properly release workflow context
bergundy 4e49875
Add documentation and restructure for better readability
bergundy 38f628e
Merge remote-tracking branch 'origin/master' into eager-workflow-disp…
bergundy fc50446
Fix lint
bergundy 15158f9
Run go-generate
bergundy cc64258
Fix nolint directive
bergundy 06aebdc
More restructuring, get rid of cyclo complexity
bergundy f32e716
Fix task inflight condition
bergundy bb00ebe
Merge branch 'master' into eager-workflow-dispatch
bergundy 6394cbb
Merge remote-tracking branch 'origin/master' into eager-workflow-disp…
bergundy 8dba7ff
Merge branch 'master' into eager-workflow-dispatch
bergundy 593a669
Address review comments
bergundy a01484b
Merge remote-tracking branch 'origin/master' into eager-workflow-disp…
bergundy 7dae88e
Merge remote-tracking branch 'origin/master' into eager-workflow-disp…
bergundy 9a3a16e
Address review comments
bergundy 41296fc
Fix missing reason tag value
bergundy 65f9726
Merge remote-tracking branch 'origin/master' into eager-workflow-disp…
bergundy efece49
Add missing nil check
bergundy f23a706
Merge remote-tracking branch 'origin/master' into eager-workflow-disp…
bergundy ab77d10
Merge remote-tracking branch 'origin/master' into eager-workflow-disp…
bergundy e0a69c2
Address review comments
bergundy efd06d7
Merge remote-tracking branch 'origin/master' into eager-workflow-disp…
bergundy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the first usage of
startRequest.StartRequest
that I see in this function, so I'm worried about potential NPEs. How do we know this is always non-nil?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't, we count on this request to be validated before this method is called.