Add RefreshPerNSWorkerManager and RemoveOverride for tests #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2023
yiminc
reviewed
Jan 26, 2023
| wm.lock.Lock() | ||
| defer wm.lock.Unlock() | ||
| for _, worker := range wm.workers { | ||
| go worker.refreshWithExistingNamespace() |
There was a problem hiding this comment.
is it possible that refershAll get called multiple times before refreshWithExistingNamespace() finished and end up having multiple goroutines running refreshWithExistingNamespace()?
There was a problem hiding this comment.
Yes, that's possible before this change too. The refresh* functions are written so that it's ok, they use a lock and some state to synchronize. The worst that should happen is extra calls to get dynamicconfig values
yiminc
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add
RefreshPerNSWorkerManagerto worker service, andRemoveOverrideto integration test dynamic config.Why?
These can be used to adjust dynamic config that applies to per-ns-worker or its components, for a single integration test. These will be used in upcoming PRs.
How did you test it?
Used in upcoming PRs
Potential risks
Only used in tests
Is hotfix candidate?