Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 Provider doesn't expose a way to pass in the SessionToken #17

Closed
thorfour opened this issue Jul 28, 2022 · 0 comments · Fixed by #41
Closed

S3 Provider doesn't expose a way to pass in the SessionToken #17

thorfour opened this issue Jul 28, 2022 · 0 comments · Fixed by #41

Comments

@thorfour
Copy link

👋 I'm trying to use the objstore with S3, and need to provide the sdk with a session token.

I'm attempting to use the NewBucketWithConfig and using dynamic credentials but the config object only exposes the
AccessKey and SecretKey but not the SessionToken is this something that could be added?

I'm happy to submit the PR but just wanted to see if there was a reason that was left out of the config?
farodin91 added a commit to farodin91/thanos-objstore that referenced this issue Jan 13, 2023
@farodin91
s3: add support for session token
9405504 
Fixes thanos-io#17

Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
@farodin91 farodin91 mentioned this issue Jan 13, 2023
Merged
2 tasks
matej-g pushed a commit that referenced this issue Jan 31, 2023
@farodin91
s3: add support for session token (#41)
3cac994 
Fixes #17

Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

s3: add support for session token farodin91/thanos-objstore
1 participant
@thorfour