s3: add support for session token #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farodin91
force-pushed
the
s3-add-support-for-session-token
branch
from
0e387d6
to
0dea180
Compare
Fixes thanos-io#17 Signed-off-by: Jan Jansen <jan.jansen@gdata.de>
farodin91
force-pushed
the
s3-add-support-for-session-token
branch
from
0dea180
to
9405504
Compare
|
@matej-g does this pr gets merged any time soon? Thanks |
|
@farodin91 sorry for the delay, this looks good to me and since there were no objections / more reviews, I'm merging. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Changes
Verification