Use original file in rules loaded metric

[yeya24]

Signed-off-by: yeya24 yb532204897@gmail.com

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

Changes

Use the original rule file name as the label in load rules metric

Verification

[yeya24]

There are still some wrong metrics exported by rule manager, but now I don't figure out how to fix them, it may change a lot

curl http://localhost:10908/metrics | grep data/.tmp

prometheus_rule_group_interval_seconds{rule_group="data/.tmp-rules/valid.yaml.96e6e93b5a37e1df396d2d69d8cdba3ec79dd212157123e6bcc2045f28033275.WARN;test-alert-group",strategy="warn"} 5
prometheus_rule_group_interval_seconds{rule_group="data/.tmp-rules/valid.yaml.96e6e93b5a37e1df396d2d69d8cdba3ec79dd212157123e6bcc2045f28033275.WARN;test-alert-group1",strategy="warn"} 5
prometheus_rule_group_last_duration_seconds{rule_group="data/.tmp-rules/valid.yaml.96e6e93b5a37e1df396d2d69d8cdba3ec79dd212157123e6bcc2045f28033275.WARN;test-alert-group",strategy="warn"} 0.001195467
prometheus_rule_group_last_duration_seconds{rule_group="data/.tmp-rules/valid.yaml.96e6e93b5a37e1df396d2d69d8cdba3ec79dd212157123e6bcc2045f28033275.WARN;test-alert-group1",strategy="warn"} 0.002537008
prometheus_rule_group_last_evaluation_timestamp_seconds{rule_group="data/.tmp-rules/valid.yaml.96e6e93b5a37e1df396d2d69d8cdba3ec79dd212157123e6bcc2045f28033275.WARN;test-alert-group",strategy="warn"} 1.575936400578541e+09
prometheus_rule_group_last_evaluation_timestamp_seconds{rule_group="data/.tmp-rules/valid.yaml.96e6e93b5a37e1df396d2d69d8cdba3ec79dd212157123e6bcc2045f28033275.WARN;test-alert-group1",strategy="warn"} 1.575936402443577e+09
prometheus_rule_group_rules{rule_group="data/.tmp-rules/valid.yaml.96e6e93b5a37e1df396d2d69d8cdba3ec79dd212157123e6bcc2045f28033275.WARN;test-alert-group",strategy="warn"} 1
prometheus_rule_group_rules{rule_group="data/.tmp-rules/valid.yaml.96e6e93b5a37e1df396d2d69d8cdba3ec79dd212157123e6bcc2045f28033275.WARN;test-alert-group1",strategy="warn"} 1

[bwplotka]

Thanks for noticing this. It's not perfect.

What I will propose is to actually propose PartialResponseStrategy on Rules and Alerts in the upstream Prometheus. This might be as well needed as even Prometheus has something like res.Warnings in places like rule/alert evaluation: https://github.com/prometheus/prometheus/blob/06066a3619f0561a6e048b8c7cb874985c5a443b/rules/manager.go#L169

This will make native rule/alert being compatible with Thanos one, thus solving this. (:

cc @simonpasquier if that makes sesne (:

[simonpasquier]

@bwplotka interesting idea indeed!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[bwplotka]

It's stale but also it's really quite bad -> it introduces some unnecessary cardinality. Let's fix it!

LGTM 👍

[stale]

This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions.

[yeya24]

This PR is still valid.

[stale]

This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions.

[yeya24]

Sorry about that. Just notice I need a rebase in this PR... Is it possible to make this open?

[bwplotka]

Of course. I think you have permission to do so, no?

…

On Sun, 29 Mar 2020 at 05:08, Ben Ye ***@***.***> wrote: Sorry about that. Just notice I need a rebase in this PR... Is it possible to make this open? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1857 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVA3OZSCT4CXNW5F4BUEH3RJ3CURANCNFSM4JYVBC5Q> .

[yeya24]

I don't have the permission to re-open it.

[bwplotka]

I cannot as well and this is why: