Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use original file name in rules loaded metric #2770

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Use original file name in rules loaded metric #2770

merged 1 commit into from
Jun 16, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jun 16, 2020

Signed-off-by: yeya24 yb532204897@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Continue this pr #1857

Verification

@yeya24
use original file name in rules loaded metric
750c563 
Signed-off-by: yeya24 <yb532204897@gmail.com>
GiedriusS
GiedriusS approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@GiedriusS
Copy link
Member

Old:

thanos_rule_loaded_rules{file="data/.tmp-rules/rules.yml.1b84a2b1fa3ea29dafafba46eae10e4c53225102cd8b8faff901b49c25c4cd43.ABORT",group="example",strategy="ABORT"} 1

New:

thanos_rule_loaded_rules{file="data/rules.yml",group="example",strategy="ABORT"} 1

@GiedriusS GiedriusS merged commit 1483f69 into thanos-io:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeya24 @GiedriusS