Release 0.2.0 #21
Merged
Release 0.2.0 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent upon --help flag
* Fixing version output by adding the version attribute using commander * Adding quotes to version number
…isted in package.json
a response of length 0
* Setting up chalk support * Adding red to errors and adding cyan to the divider. Keeping the definition in white
* Add contributing guidelines * Add contributing to readme. * Update Contributing gudelines
|
Should we be merging this with merge commit or squash? Thoughts? |
|
@rainrivas I think we can merge w/o squash. |
|
@jwu910 so we will merge commit right? (I am pretty sure you don't rebase commits if it's a release) |
|
@rainrivas Correct. I can agree with that. Merge commit for releases. |
jwu910
approved these changes
Jan 15, 2018
| } | ||
| }); | ||
| trimRes.forEach((result) => { | ||
| if (typeof (result.definition) !== undefined) { |
There was a problem hiding this comment.
Is there a case that this would be undefined?
There was a problem hiding this comment.
@jwu910 if there is a bad response and the response doesn't have a "definition" element. It's sort of a catch all. For example
{
"tags": [],
"result_type": "no_results",
"list": [],
"sounds": []
}
vs actually finding results
{
"tags": [
"sleng",
"colloquialism",
"neologism",
"slang"
],
"result_type": "exact",
"list": [
{
"definition": "SLNG is actually slang for...slang.",
"permalink": "http://slng.urbanup.com/1146042",
"thumbs_up": 9,
"author": "DaWhitey",
"word": "slng",
"defid": 1146042,
"current_vote": "",
"example": "Mah is slng for My \"Ur slng so cheep\"",
"thumbs_down": 4
}
],
"sounds": []
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently published v0.2.0 as slng@beta on npm.
Once PR is merged, I'll republish and tag as slng@latest
Fixes
-V, --version