Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NK87 #256

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Add NK87 #256

merged 2 commits into from
Aug 10, 2020

Conversation

yiancar
Copy link
Collaborator

@yiancar yiancar commented Aug 7, 2020

Description

Relevant QMK commit: qmk/qmk_firmware#9965

QMK Pull Request

Checklist

  • The QMK source code follows the guide here: https://caniusevia.com/docs/configuring_qmk
  • The VIA definition follows the guide here: https://caniusevia.com/docs/layouts
  • I have tested this keyboard definition using VIA's "Design" tab.
  • I have tested this keyboard definition with firmware on a device.
  • I have assigned alpha keys and modifier keys with the correct colors.
  • The Vendor ID is not 0xFEED

@wilba wilba added the pending QMK merge Waiting for merge into QMK master label Aug 10, 2020
@wilba
Copy link
Contributor

wilba commented Aug 10, 2020

@yiancar pls... alpha colored nav keys and F keys? Mod colored backslash? ACCENT SPACEBAR ON A TKL??? SMH....

;-)

@yiancar
Copy link
Collaborator Author

yiancar commented Aug 10, 2020

whatever I do is wrong :(((((

@yiancar
Copy link
Collaborator Author

yiancar commented Aug 10, 2020

fixed

@wilba wilba merged commit dfc55c1 into the-via:master Aug 10, 2020
@yiancar yiancar deleted the nk87 branch August 10, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending QMK merge Waiting for merge into QMK master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants