Fix ANALYZE on dist hypertable for a set of nodes #4522

pmwkaa · 2022-07-18T11:51:39Z

Make sure ANALYZE can be run on a specific set of data nodes
assigned to the distributed hypertable.

codecov · 2022-07-18T12:01:15Z

Codecov Report

Merging #4522 (9e96da6) into main (63a80ee) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #4522      +/-   ##
==========================================
- Coverage   90.23%   90.18%   -0.05%     
==========================================
  Files         222      222              
  Lines       41089    41088       -1     
==========================================
- Hits        37076    37056      -20     
- Misses       4013     4032      +19

Impacted Files	Coverage Δ
src/telemetry/functions.c	`4.87% <0.00%> (+0.03%)`	⬆️
tsl/src/chunk_api.c	`94.91% <100.00%> (+<0.01%)`	⬆️
src/bgw/scheduler.c	`82.89% <0.00%> (-3.54%)`	⬇️
src/loader/bgw_message_queue.c	`85.52% <0.00%> (-2.64%)`	⬇️
tsl/src/remote/dist_commands.c	`92.95% <0.00%> (-0.94%)`	⬇️
src/bgw/job.c	`93.14% <0.00%> (-0.29%)`	⬇️
tsl/src/reorder.c	`85.37% <0.00%> (-0.27%)`	⬇️
tsl/src/bgw_policy/job.c	`88.62% <0.00%> (-0.05%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca3c85b...9e96da6. Read the comment docs.

nikkhils

LGTM!

svenklemm · 2022-07-19T16:41:58Z

Needs changelog entry

Make sure ANALYZE can be run on a specific set of data nodes assigned to the distributed hypertable Fix timescale#4508

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * timescale#4517 Fix prepared statement param handling in ChunkAppend * timescale#4522 Fix ANALYZE on dist hypertable for a set of nodes * timescale#4526 Fix gapfill group comparison for TOASTed values * timescale#4527 Handle stats properly for range types * timescale#4532 Fix memory leak in function telemetry * timescale#4534 Use explicit memory context with hash_create * timescale#4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill , @hongquani, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * timescale#4517 Fix prepared statement param handling in ChunkAppend * timescale#4522 Fix ANALYZE on dist hypertable for a set of nodes * timescale#4526 Fix gapfill group comparison for TOASTed values * timescale#4527 Handle stats properly for range types * timescale#4532 Fix memory leak in function telemetry * timescale#4534 Use explicit memory context with hash_create * timescale#4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill , @hongquani, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * timescale#4517 Fix prepared statement param handling in ChunkAppend * timescale#4522 Fix ANALYZE on dist hypertable for a set of nodes * timescale#4526 Fix gapfill group comparison for TOASTed values * timescale#4527 Handle stats properly for range types * timescale#4532 Fix memory leak in function telemetry * timescale#4534 Use explicit memory context with hash_create * timescale#4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

pmwkaa requested a review from a team as a code owner July 18, 2022 11:51

pmwkaa requested review from RafiaSabih and konskov and removed request for a team July 18, 2022 11:51

pmwkaa self-assigned this Jul 18, 2022

svenklemm approved these changes Jul 18, 2022

View reviewed changes

nikkhils approved these changes Jul 18, 2022

View reviewed changes

pmwkaa force-pushed the analyze_dist_fix branch from 3beb252 to 9b9e5a0 Compare July 21, 2022 07:23

Fix ANALYZE on dist hypertable for a set of nodes

9e96da6

Make sure ANALYZE can be run on a specific set of data nodes assigned to the distributed hypertable Fix timescale#4508

pmwkaa force-pushed the analyze_dist_fix branch from 9b9e5a0 to 9e96da6 Compare July 21, 2022 08:57

pmwkaa merged commit 4ed116b into timescale:main Jul 21, 2022

svenklemm mentioned this pull request Jul 22, 2022

Release 2.7.2 #4535

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix ANALYZE on dist hypertable for a set of nodes #4522

Fix ANALYZE on dist hypertable for a set of nodes #4522

pmwkaa commented Jul 18, 2022

codecov bot commented Jul 18, 2022 •

edited

Loading

nikkhils left a comment

svenklemm commented Jul 19, 2022

Fix ANALYZE on dist hypertable for a set of nodes #4522

Fix ANALYZE on dist hypertable for a set of nodes #4522

Conversation

pmwkaa commented Jul 18, 2022

codecov bot commented Jul 18, 2022 • edited Loading

Codecov Report

nikkhils left a comment

Choose a reason for hiding this comment

svenklemm commented Jul 19, 2022

codecov bot commented Jul 18, 2022 •

edited

Loading