Handle stats properly for range types #4527

nikkhils · 2022-07-19T13:46:55Z

For range types, the operator entry in statistics table is invalid.
Also, certain range types don't have "VALUES" but only have "NUMBERS"
entries.

codecov · 2022-07-19T14:00:55Z

Codecov Report

Merging #4527 (bc182fc) into main (d561928) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4527      +/-   ##
==========================================
+ Coverage   90.20%   90.23%   +0.02%     
==========================================
  Files         222      222              
  Lines       41088    41088              
==========================================
+ Hits        37065    37074       +9     
+ Misses       4023     4014       -9

Impacted Files	Coverage Δ
tsl/src/chunk_api.c	`94.90% <100.00%> (+<0.01%)`	⬆️
tsl/src/reorder.c	`85.37% <0.00%> (-0.27%)`	⬇️
tsl/src/bgw_policy/job.c	`88.62% <0.00%> (-0.05%)`	⬇️
src/bgw/job.c	`93.42% <0.00%> (+0.28%)`	⬆️
src/bgw/scheduler.c	`86.43% <0.00%> (+2.65%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9dd3c...bc182fc. Read the comment docs.

nikkhils · 2022-07-19T14:17:52Z

Resolves https://github.com/timescale/Support-Dev-Collab/issues/500

tsl/src/chunk_api.c

svenklemm · 2022-07-19T16:41:16Z

Please dont forget to add changelog entry

For range types, the operator entry in statistics table is invalid. Also, certain range types don't have "VALUES" but only have "NUMBERS" entries.

nikkhils · 2022-07-20T06:36:40Z

Please dont forget to add changelog entry

Added changelog entry as well

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * timescale#4517 Fix prepared statement param handling in ChunkAppend * timescale#4522 Fix ANALYZE on dist hypertable for a set of nodes * timescale#4526 Fix gapfill group comparison for TOASTed values * timescale#4527 Handle stats properly for range types * timescale#4532 Fix memory leak in function telemetry * timescale#4534 Use explicit memory context with hash_create * timescale#4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill , @hongquani, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * timescale#4517 Fix prepared statement param handling in ChunkAppend * timescale#4522 Fix ANALYZE on dist hypertable for a set of nodes * timescale#4526 Fix gapfill group comparison for TOASTed values * timescale#4527 Handle stats properly for range types * timescale#4532 Fix memory leak in function telemetry * timescale#4534 Use explicit memory context with hash_create * timescale#4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill , @hongquani, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * timescale#4517 Fix prepared statement param handling in ChunkAppend * timescale#4522 Fix ANALYZE on dist hypertable for a set of nodes * timescale#4526 Fix gapfill group comparison for TOASTed values * timescale#4527 Handle stats properly for range types * timescale#4532 Fix memory leak in function telemetry * timescale#4534 Use explicit memory context with hash_create * timescale#4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

@3a6u9ka

This release is a patch release. We recommend that you upgrade at the next available opportunity. Among other things this release fixes several memory leaks, handling of TOASTed values in GapFill and parameter handling in prepared statements. **Bugfixes** * #4517 Fix prepared statement param handling in ChunkAppend * #4522 Fix ANALYZE on dist hypertable for a set of nodes * #4526 Fix gapfill group comparison for TOASTed values * #4527 Handle stats properly for range types * #4532 Fix memory leak in function telemetry * #4534 Use explicit memory context with hash_create * #4538 Fix chunk creation on hypertables with non-default statistics **Thanks** * @3a6u9ka, @bgemmill, @hongquan, @stl-leonid-kalmaev and @victor-sudakov for reporting a memory leak * @hleung2021 and @laocaixw for reporting an issue with parameter handling in prepared statements

nikkhils requested a review from a team as a code owner July 19, 2022 13:46

nikkhils self-assigned this Jul 19, 2022

nikkhils requested review from pmwkaa and erimatnor and removed request for a team July 19, 2022 13:46

nikkhils force-pushed the rng_stats branch from a83e8f0 to 8b28fbd Compare July 19, 2022 13:48

nikkhils requested review from svenklemm and mkindahl July 19, 2022 13:48

svenklemm approved these changes Jul 19, 2022

View reviewed changes

fabriziomello reviewed Jul 19, 2022

View reviewed changes

tsl/src/chunk_api.c Outdated Show resolved Hide resolved

nikkhils force-pushed the rng_stats branch from 8b28fbd to 9883bb8 Compare July 19, 2022 15:36

fabriziomello approved these changes Jul 19, 2022

View reviewed changes

Handle stats properly for range types

bc182fc

For range types, the operator entry in statistics table is invalid. Also, certain range types don't have "VALUES" but only have "NUMBERS" entries.

nikkhils force-pushed the rng_stats branch from 9883bb8 to bc182fc Compare July 20, 2022 06:36

nikkhils merged commit 63a80ee into timescale:main Jul 20, 2022

nikkhils deleted the rng_stats branch July 20, 2022 07:01

svenklemm added this to the TimescaleDB 2.7.2 milestone Jul 21, 2022

svenklemm mentioned this pull request Jul 22, 2022

Release 2.7.2 #4535

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle stats properly for range types #4527

Handle stats properly for range types #4527

nikkhils commented Jul 19, 2022

codecov bot commented Jul 19, 2022 •

edited

Loading

nikkhils commented Jul 19, 2022

svenklemm commented Jul 19, 2022

nikkhils commented Jul 20, 2022

Handle stats properly for range types #4527

Handle stats properly for range types #4527

Conversation

nikkhils commented Jul 19, 2022

codecov bot commented Jul 19, 2022 • edited Loading

Codecov Report

nikkhils commented Jul 19, 2022

svenklemm commented Jul 19, 2022

nikkhils commented Jul 20, 2022

codecov bot commented Jul 19, 2022 •

edited

Loading