Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CAgg on CAgg bucket size validation #5072

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Dec 9, 2022

The bucket size of a Continuous Aggregate should be greater or equal to
the parent Continuous Aggregate because there are many cases where you
actually want to roll up on another dimension.

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #5072 (54f96a7) into main (08bb21f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5072      +/-   ##
==========================================
+ Coverage   89.64%   89.70%   +0.05%     
==========================================
  Files         227      227              
  Lines       51738    51648      -90     
==========================================
- Hits        46380    46329      -51     
+ Misses       5358     5319      -39     
Impacted Files Coverage Δ
src/bgw/job_stat.c 92.18% <100.00%> (ø)
tsl/src/compression/create.c 96.28% <100.00%> (+0.03%) ⬆️
tsl/src/continuous_aggs/create.c 87.90% <100.00%> (ø)
src/loader/bgw_launcher.c 89.51% <0.00%> (-2.55%) ⬇️
src/loader/bgw_message_queue.c 86.36% <0.00%> (-2.28%) ⬇️
src/bgw/scheduler.c 83.41% <0.00%> (-1.75%) ⬇️
tsl/src/compression/compression.c 96.04% <0.00%> (-0.39%) ⬇️
tsl/src/debug.c 49.36% <0.00%> (-0.33%) ⬇️
tsl/src/compression/api.c 95.57% <0.00%> (-0.25%) ⬇️
tsl/src/reorder.c 85.87% <0.00%> (-0.23%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5e496a...54f96a7. Read the comment docs.

Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tsl/test/expected/cagg_on_cagg_integer.out Outdated Show resolved Hide resolved
@fabriziomello fabriziomello force-pushed the fix_cagg_on_cagg_bucket_size_validation branch from c92eb63 to 265ccaa Compare December 20, 2022 13:08
@fabriziomello fabriziomello added this to the TimescaleDB 2.9.1 milestone Dec 20, 2022
@fabriziomello fabriziomello force-pushed the fix_cagg_on_cagg_bucket_size_validation branch from 265ccaa to 27e461c Compare December 20, 2022 15:22
@fabriziomello fabriziomello enabled auto-merge (rebase) December 20, 2022 15:22
The bucket size of a Continuous Aggregate should be greater or equal to
the parent Continuous Aggregate because there are many cases where you
actually want to roll up on another dimension.
@fabriziomello fabriziomello force-pushed the fix_cagg_on_cagg_bucket_size_validation branch from 27e461c to 54f96a7 Compare December 20, 2022 15:42
@fabriziomello fabriziomello merged commit 024b1e1 into timescale:main Dec 20, 2022
svenklemm added a commit to svenklemm/timescaledb that referenced this pull request Dec 23, 2022
This release contains bug fixes since the 2.9.0 release.
This release is high priority for upgrade. We strongly recommend that you
upgrade as soon as possible.

**Bugfixes**
* timescale#5072 Fix CAgg on CAgg bucket size validation
* timescale#5101 Fix enabling compression on caggs with renamed columns
* timescale#5106 Fix building against PG15 on Windows
* timescale#5117 Fix postgres server restart on background worker exit
* timescale#5121 Fix privileges for job_errors in update script
@svenklemm svenklemm mentioned this pull request Dec 23, 2022
svenklemm added a commit that referenced this pull request Dec 23, 2022
This release contains bug fixes since the 2.9.0 release.
This release is high priority for upgrade. We strongly recommend that you
upgrade as soon as possible.

**Bugfixes**
* #5072 Fix CAgg on CAgg bucket size validation
* #5101 Fix enabling compression on caggs with renamed columns
* #5106 Fix building against PG15 on Windows
* #5117 Fix postgres server restart on background worker exit
* #5121 Fix privileges for job_errors in update script
svenklemm added a commit that referenced this pull request Dec 23, 2022
This release contains bug fixes since the 2.9.0 release.
This release is high priority for upgrade. We strongly recommend that you
upgrade as soon as possible.

**Bugfixes**
* #5072 Fix CAgg on CAgg bucket size validation
* #5101 Fix enabling compression on caggs with renamed columns
* #5106 Fix building against PG15 on Windows
* #5117 Fix postgres server restart on background worker exit
* #5121 Fix privileges for job_errors in update script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants