-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix postgres server restart on background worker exit #5117
Conversation
just testing |
Codecov Report
@@ Coverage Diff @@
## main #5117 +/- ##
==========================================
- Coverage 89.45% 89.45% -0.01%
==========================================
Files 227 227
Lines 51618 51614 -4
==========================================
- Hits 46174 46170 -4
Misses 5444 5444
Continue to review full report at Codecov.
|
@@ -1163,7 +1140,7 @@ ts_bgw_job_entrypoint(PG_FUNCTION_ARGS) | |||
* not respect critical sections. We install an silent signal handler for | |||
* invisible jobs, which will then die without printing an error message. | |||
*/ | |||
pqsignal(SIGTERM, params.croak_silently ? croak : die); | |||
pqsignal(SIGTERM, die); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove reference to other function in comment above.
8a96f40
to
a46e7b4
Compare
Fixed by removing the croak signal handler that was introduced to enable the silent exit of the telemetry job.
This release contains bug fixes since the 2.9.0 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * timescale#5072 Fix CAgg on CAgg bucket size validation * timescale#5101 Fix enabling compression on caggs with renamed columns * timescale#5106 Fix building against PG15 on Windows * timescale#5117 Fix postgres server restart on background worker exit * timescale#5121 Fix privileges for job_errors in update script
This release contains bug fixes since the 2.9.0 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * #5072 Fix CAgg on CAgg bucket size validation * #5101 Fix enabling compression on caggs with renamed columns * #5106 Fix building against PG15 on Windows * #5117 Fix postgres server restart on background worker exit * #5121 Fix privileges for job_errors in update script
This release contains bug fixes since the 2.9.0 release. This release is high priority for upgrade. We strongly recommend that you upgrade as soon as possible. **Bugfixes** * #5072 Fix CAgg on CAgg bucket size validation * #5101 Fix enabling compression on caggs with renamed columns * #5106 Fix building against PG15 on Windows * #5117 Fix postgres server restart on background worker exit * #5121 Fix privileges for job_errors in update script
No description provided.