Fix segfault in cagg_validate_query #6655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabriziomello, @gayyappan: please review this pull request.
|
fabriziomello
approved these changes
Feb 14, 2024
svenklemm
force-pushed
the
cagg_validate_query
branch
from
64bcbb6
to
089b48a
Compare
jnidzwetzki
approved these changes
Feb 14, 2024
svenklemm
force-pushed
the
cagg_validate_query
branch
from
089b48a
to
58a03f9
Compare
When the input to pg_parse_query does not contain anything to parse it will return NIL. This patch adds a check for NIL to prevent the segfault that would otherwise happen later in the code. Fixes: #6625
svenklemm
force-pushed
the
cagg_validate_query
branch
from
58a03f9
to
cd53ba3
Compare
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 19, 2024
This release contains bug fixes since the 2.14.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6655 Fix segfault in cagg_validate_query * timescale#6660 Fix refresh on empty CAgg with variable bucket * timescale#6670 Don't try to compress osm chunks **Thanks** * @kav23alex for reporting a segfault in cagg_validate_query
svenklemm
added a commit
that referenced
this pull request
Feb 20, 2024
This release contains bug fixes since the 2.14.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #6655 Fix segfault in cagg_validate_query * #6660 Fix refresh on empty CAgg with variable bucket * #6670 Don't try to compress osm chunks **Thanks** * @kav23alex for reporting a segfault in cagg_validate_query
svenklemm
added a commit
that referenced
this pull request
Feb 20, 2024
This release contains bug fixes since the 2.14.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #6655 Fix segfault in cagg_validate_query * #6660 Fix refresh on empty CAgg with variable bucket * #6670 Don't try to compress osm chunks **Thanks** * @kav23alex for reporting a segfault in cagg_validate_query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the input to pg_parse_query does not contain anything to parse it will return NIL. This patch adds a check for NIL to prevent the segfault that would otherwise happen later in the code.
Fixes: #6625