Fix refresh on empty CAgg with variable bucket #6660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnidzwetzki
force-pushed
the
cagg_range_undefined
branch
from
091efc5
to
3794b97
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6660 +/- ##
==========================================
+ Coverage 80.06% 81.57% +1.51%
==========================================
Files 190 190
Lines 37181 36307 -874
Branches 9450 9435 -15
==========================================
- Hits 29770 29619 -151
+ Misses 2997 2940 -57
+ Partials 4414 3748 -666 ☔ View full report in Codecov by Sentry. |
jnidzwetzki
force-pushed
the
cagg_range_undefined
branch
from
3794b97
to
97ed73a
Compare
|
@fabriziomello, @svenklemm: please review this pull request.
|
jnidzwetzki
force-pushed
the
cagg_range_undefined
branch
3 times, most recently
from
be0d8d0
to
c6313b6
Compare
So far, we have not handled CAggs with variable buckets correctly. The CAgg refresh on a hypertable without any data lead to the error message "timestamp out of range". This patch fixes the problem by declaring empty CAggs as up-to-date.
jnidzwetzki
force-pushed
the
cagg_range_undefined
branch
from
c6313b6
to
29e1dd1
Compare
fabriziomello
approved these changes
Feb 15, 2024
konskov
approved these changes
Feb 16, 2024
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 19, 2024
This release contains bug fixes since the 2.14.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#6655 Fix segfault in cagg_validate_query * timescale#6660 Fix refresh on empty CAgg with variable bucket * timescale#6670 Don't try to compress osm chunks **Thanks** * @kav23alex for reporting a segfault in cagg_validate_query
svenklemm
added a commit
that referenced
this pull request
Feb 20, 2024
This release contains bug fixes since the 2.14.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #6655 Fix segfault in cagg_validate_query * #6660 Fix refresh on empty CAgg with variable bucket * #6670 Don't try to compress osm chunks **Thanks** * @kav23alex for reporting a segfault in cagg_validate_query
svenklemm
added a commit
that referenced
this pull request
Feb 20, 2024
This release contains bug fixes since the 2.14.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #6655 Fix segfault in cagg_validate_query * #6660 Fix refresh on empty CAgg with variable bucket * #6670 Don't try to compress osm chunks **Thanks** * @kav23alex for reporting a segfault in cagg_validate_query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we have not handled CAggs with variable buckets correctly. The CAgg refresh on a hypertable without any data lead to the error message "timestamp out of range". This patch fixes the problem by declaring empty CAggs as up-to-date.