Add ls option to cli

[pythops]

No description provided.

[tony]

Nice @pythops ! (Also nice username!)

Can you add a test? (e.g. https://github.com/tmux-python/tmuxp/blob/master/tests/test_cli.py)?

[pythops]

Thanks @tony :)
Always a pleasure to contribute.

[tony]

@pythops I will take a look at this tomorrow

I need to take a look at why Travis isn't triggering.

[tony]

@pythops https://travis-ci.org/github/tmux-python/tmuxp

Can you see this? https://travis-ci.org/github/tmux-python/tmuxp/jobs/702700298

[tony]

I will take a peek tomorrow. It looks like there's another error happening at the same time not related to this PR.

[tony]

Looks good! Some change requests

Additionally, can you do a rebase against master so the latest fixes for travis CI are in?

I'm not sure what your repo layout is like (git remotes) but it's something like this:

git remote -v

Assuming your origin is:

origin  https://github.com/tmux-python/tmuxp.git (fetch)
origin  https://github.com/tmux-python/tmuxp.git (push)

git pull --rebase origin master
git push --force-with-lease

If origin is your own branch, git remote add upstream https://github.com/tmux-python/tmuxp.git and do this:

git pull --rebase upstream master
git push --force-with-lease

[pythops]

@tony Would you mind restart the tests, they should pass.
Thanks

[tony]

@pythops Restarted

[tony]

@pythops You can also rebase again - I did several fixes to travis since you last pushed

[pythops]

The CI failed because of poetry. Maybe it should be restarted again as I did the rebase after.

[tony]

@pythops

You need to rebase the against my master branch - which has poetry - and force push it. It's not easy to give instructions on since I don't know how you have git remote names configured.

Side note: It's really difficult to find a tutorial online that's satisfactory for me to explain - since it really hinges on your local github layout and how you have git remote set. Sorry about that!

When you rebase your branch against my master branch at tmux-python/tmuxp, it will rewrite your commits on top of the latest code.

Can you give me access to your forked repo? I can do it for you

[tony]

@pythops Hm, try this:

git remote add pythops https://github.com/tmux-python/tmuxp.git
git fetch pythops
git checkout -b add-ls-option
git reset --hard pythops/master
git push -u pythops add-ls-option

This assures that:

1. you are using pythops as a remote for your own repo, so we're referring to the same git repo.
2. you aren't using master as a branch for a change, since those are better kept in their own specific branches, e.g. add-ls-option
3. the branch add-ls-option is set-upstream to push to your repo at add-ls-option in future commits

You should see an option to open a new pull request, go ahead and do it if you'd like

Now, to rebase so your work is based on the latest tmuxp:

git remote add tmux-python https://github.com/tmux-python/tmuxp.git
git fetch tmux-python
git pull --rebase tmux-python master --autostash
git push --force-with-lease

[pythops]

@tony you should have access to my fork

[tony]

[tony]

Sorry about that, not sure why the branch closed

[tony]

@pythops In what sense do I have access to your repo? I don't seem to be able to push branches

See #616, I PR'd it, but the problem is - I'd sort of take credit for your work.

I want to make sure you get credit for the Pull request/commits. I think you need to redo it and rebase correctly - it's really up to your system and reading up on rebasing, I wrote more here: #599 (comment)

Do you want to make your own pull request? If so, I think you need to figure out the branching and make a new PR. If I do it for you, I end up becoming the creator of the PR and part of the commit messages.

[tony]

Also sorry for all the trouble with this PR!

Initially our CI system was broke. And rebasing it kind of tricky to explain without me knowing your configuration. If I gave instructions and the remote names didn't match, the instructions wouldn't work.