Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ls option #616

Merged
merged 8 commits into from
Jul 10, 2020
Merged

Add ls option #616

merged 8 commits into from
Jul 10, 2020

Conversation

tony
Copy link
Member

@tony tony commented Jul 9, 2020

#599 rebased

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #616 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #616   +/-   ##
=======================================
  Coverage   78.32%   78.32%           
=======================================
  Files           5        5           
  Lines         798      798           
  Branches      232      232           
=======================================
  Hits          625      625           
  Misses        115      115           
  Partials       58       58           
Impacted Files Coverage Δ
tmuxp/cli.py 64.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f68609d...5e7b952. Read the comment docs.

@tony tony mentioned this pull request Jul 9, 2020
@tony
Copy link
Member Author

tony commented Jul 9, 2020

@pythops Do you want to make your own pull request / redo the branch ? (So you get full credit for this?)

I can wait as long as you'd like! No hurry!

@pythops
Copy link
Contributor

pythops commented Jul 9, 2020

@tony Just merge it :)
I'm more interested in making the tool better than getting the credits to flatter my ego ;)

@tony tony merged commit 12764fb into master Jul 10, 2020
@tony
Copy link
Member Author

tony commented Jul 10, 2020

@pythops Merged! Thank you for the contribution and the tests!

I updated tests and switched it to use glob (since it's easier on package maintainers downstream, pathlib exists in our pyproject.toml, but it's only a test dependency)

@tony tony deleted the add-ls-option branch July 10, 2020 12:57
@pythops
Copy link
Contributor

pythops commented Jul 10, 2020

@tony glad to contribute :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants