Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just learned about this
asm!
feature, which prompted me to look at whether we were using it.Not sure if some of the others were options when #381 was written, but strictly speaking arm cores are defined to follow the
AAPCS
on exception entry/exit. In practice, I thinkC
andaapcs
(and the others here) are just aliases that do the same thing. Nonetheless, just in case, we should probably put the 'most correct' name here.Relevant doc: https://doc.rust-lang.org/nightly/reference/inline-assembly.html#abi-clobbers