Skip to content

Commit

Permalink
Merge pull request #3257 from bdarnell/build-workflow-wstest-warning
Browse files Browse the repository at this point in the history
test: Close a websocket client that causes occasional test failures
  • Loading branch information
bdarnell authored Apr 24, 2023
2 parents fcb09eb + f5a1d5c commit e0fa53e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
name: Upload to PyPI (test)
needs: [build_wheels, build_sdist]
runs-on: ubuntu-22.04
if: github.event_name == 'push' && startsWith(github.ref_name, 'build-workflow')
if: github.repository == 'tornadoweb/tornado' && github.event_name == 'push' && startsWith(github.ref_name, 'build-workflow')
steps:
- uses: actions/download-artifact@v3
with:
Expand All @@ -86,7 +86,7 @@ jobs:
name: Upload to PyPI (prod)
needs: [build_wheels, build_sdist]
runs-on: ubuntu-22.04
if: github.event_name == 'push' && github.ref_type == 'tag' && startsWith(github.ref_name, 'v')
if: github.repository == 'tornadoweb/tornado' && github.event_name == 'push' && github.ref_type == 'tag' && startsWith(github.ref_name, 'v')
steps:
- uses: actions/download-artifact@v3
with:
Expand Down
1 change: 1 addition & 0 deletions tornado/test/websocket_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,7 @@ def test_client_ping(self):
response = yield ws.read_message()
self.assertEqual(response, "got ping")
# TODO: test that the connection gets closed if ping responses stop.
ws.close()


class ManualPingTest(WebSocketBaseTestCase):
Expand Down

0 comments on commit e0fa53e

Please sign in to comment.