Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Close a websocket client that causes occasional test failures #3257

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

bdarnell
Copy link
Member

These failures occur on the build.yml workflow on the emulated arm64
platform: an ill-timed timer firing during test shutdown can result
in a message being logged and the test failing for dirty logs.

These failures occur on the build.yml workflow on the emulated arm64
platform: an ill-timed timer firing during test shutdown can result
in a message being logged and the test failing for dirty logs.
These will fail when run from forks because the necessary
credentials aren't available.
@bdarnell bdarnell merged commit e0fa53e into tornadoweb:master Apr 24, 2023
@bdarnell bdarnell deleted the build-workflow-wstest-warning branch April 24, 2023 02:56
bdarnell added a commit to bdarnell/tornado that referenced this pull request May 7, 2023
This gives a warning that is not dependent on GC for the issue
in tornadoweb#3257.
bdarnell added a commit to bdarnell/tornado that referenced this pull request May 7, 2023
This gives a warning that is not dependent on GC for the issue
in tornadoweb#3257.
bdarnell added a commit to bdarnell/tornado that referenced this pull request May 7, 2023
This gives a warning that is not dependent on GC for the issue
in tornadoweb#3257. This new warning covers all websocket client connections,
while the previous GC-dependent warning only affected those with
ping_interval set. This unfortunately introduces an effective
requirement to close all websocket clients explicitly for those
who are strict about warnings.
bdarnell added a commit to bdarnell/tornado that referenced this pull request May 8, 2023
This gives a warning that is not dependent on GC for the issue
in tornadoweb#3257. This new warning covers all websocket client connections,
while the previous GC-dependent warning only affected those with
ping_interval set. This unfortunately introduces an effective
requirement to close all websocket clients explicitly for those
who are strict about warnings.
bdarnell added a commit to bdarnell/tornado that referenced this pull request May 8, 2023
This gives a warning that is not dependent on GC for the issue
in tornadoweb#3257. This new warning covers all websocket client connections,
while the previous GC-dependent warning only affected those with
ping_interval set. This unfortunately introduces an effective
requirement to close all websocket clients explicitly for those
who are strict about warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant