-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.19.3 #50
Merged
Merged
Update to 1.19.3 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed old CreativeMode Tab methods as CreativeMode Tabs now need to be registered via a ModBus event Updated generated data/asset files Updated mod metadata files to target latest versions [Forge & pack formats] And finally a lot of whitespace changes cause IntelliJ decided it wanted to remove them
tterrag1098
requested changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to use the code generation classes to update the data providers that have generated code.
- Run the respective code generator as a main method
- Paste vanilla source code of the parent class into the console, and press enter
- Type "done" and press enter
src/main/java/com/tterrag/registrate/providers/RegistrateRecipeProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/tterrag/registrate/util/LazySpawnEggItem.java
Outdated
Show resolved
Hide resolved
src/main/java/com/tterrag/registrate/providers/RegistrateAdvancementProvider.java
Outdated
Show resolved
Hide resolved
…pattern of other DataProvider constructors
…`SimpleCookingSerializer`
tterrag1098
approved these changes
Dec 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial port & update to 1.19.3, Forge: 44.0.0
Removed old CreativeMode Tab methods as CreativeMode Tabs now need to be registered via a ModBus event
Updated generated data/asset files
Updated mod metadata files to target the latest versions [Forge & pack formats]
And finally, a lot of whitespace changes cause IntelliJ decided it wanted to remove them
Updated the README.md file to now make use of Forge Jar-in-Jar rather than Gradle Shadow