Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 1.19.3 #50

Merged
merged 9 commits into from
Dec 10, 2022
Merged

Update to 1.19.3 #50

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cda1d7e
Initial port to 1.19.3 (Forge: 44.0.0)
ApexModder Dec 8, 2022
881c576
Run the Protected Method & Source code data generators
ApexModder Dec 9, 2022
ede938e
Delete old deprecated LazySpawnEggItem, Use ForgeSpawnEggItem instead…
ApexModder Dec 9, 2022
c00cc4a
Update to RegistrateAdvancementProvider constructor to match similar …
ApexModder Dec 9, 2022
04287b6
Update to RegistrateDataProvider constructor to use the `this` keyword
ApexModder Dec 9, 2022
fcc092f
Update RegistrateRecipeProvider to longer case recipe serializers to …
ApexModder Dec 9, 2022
7984121
Implement the ItemLike onto ItemProviderEntry
ApexModder Dec 9, 2022
21f9330
Reimplement old legacy methods used to assign CreativeModeTabs to Items
ApexModder Dec 10, 2022
7202227
Update README.md to make use of Forge Jar-in-Jar
ApexModder Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update to RegistrateAdvancementProvider constructor to match similar … 
…pattern of other DataProvider constructors
  • Loading branch information
@ApexModder
ApexModder committed Dec 9, 2022
commit c00cc4a89fdaa3a4d6a90f122a6e1679b9f6a4fa
10 changes: 5 additions & 5 deletions src/main/java/com/tterrag/registrate/providers/RegistrateAdvancementProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ public class RegistrateAdvancementProvider implements RegistrateProvider, Consum

private final AbstractRegistrate<?> owner;
private final PackOutput packOutput;
private final CompletableFuture<HolderLookup.Provider> registries;
private final CompletableFuture<HolderLookup.Provider> registriesLookup;
private final List<CompletableFuture<?>> advancementsToSave = Lists.newArrayList();

public RegistrateAdvancementProvider(AbstractRegistrate<?> owner, PackOutput packOutput, CompletableFuture<HolderLookup.Provider> registriesLookup) {
public RegistrateAdvancementProvider(AbstractRegistrate<?> owner, PackOutput packOutputIn, CompletableFuture<HolderLookup.Provider> registriesLookupIn) {
this.owner = owner;
this.packOutput = packOutput;
registries = registriesLookup;
this.packOutput = packOutputIn;
this.registriesLookup = registriesLookupIn;
}

@Override
Expand All @@ -58,7 +58,7 @@ public MutableComponent desc(String category, String name, String desc) {

@Override
public CompletableFuture<?> run(CachedOutput cache) {
return registries.thenCompose(lookup -> {
return registriesLookup.thenCompose(lookup -> {
advancementsToSave.clear();

try {
Expand Down