Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .btn-subtle variant #38763

Closed
wants to merge 2 commits into from
Closed

Add .btn-subtle variant #38763

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec1e924
NEW FEATURE btn-subtle
vardhan0604 Jun 13, 2023
1231b1c
Merge branch 'main' into btn-subtle-feature
vardhan0604 Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions scss/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,39 @@
@include button-outline-variant($value);
}
}

@each $color, $value in $theme-colors {
.btn-subtle {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm wrong, it seems that you're creating several times .btn-subtle.

The goal of the issue was to create a button that could change its color and bg-color contextually. I think it's not the code proposed here and it might not be the good way to do it here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I try making a new button ??

should the code be like?
@each $color, $value in $theme-colors {
.btn-tert {
@include button-variant($value, $value);
}
}

I am kinda beginner so please don't mind me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, even if I think that this feature is needed, this might be studied a bit more, I think that this kind of feature might be thought for whole Bootstrap at the same time at a naming and code level.

Let's continue the discussion in the issue, and when everyone agrees on the solution, let's create a PR.

@if $color == "light" {
@include button-variant(
$value,
$value,
$hover-background: shade-color($value, $btn-hover-bg-shade-amount),
$hover-border: shade-color($value, $btn-hover-border-shade-amount),
$active-background: shade-color($value, $btn-active-bg-shade-amount),
$active-border: shade-color($value, $btn-active-border-shade-amount)
);
} @else if $color == "dark" {
@include button-variant(
$value,
$value,
$hover-background: tint-color($value, $btn-hover-bg-tint-amount),
$hover-border: tint-color($value, $btn-hover-border-tint-amount),
$active-background: tint-color($value, $btn-active-bg-tint-amount),
$active-border: tint-color($value, $btn-active-border-tint-amount)
);
} @else {
@include button-variant($value, $value);
}
}
}

@each $color, $value in $theme-colors {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of existing code (See l.148)

.btn-outline-#{$color} {
@include button-outline-variant($value);
}
}

// scss-docs-end btn-variant-loops


Expand Down