Add .btn-subtle variant
#38763
Add .btn-subtle variant
#38763
Conversation
| } | ||
| } | ||
|
|
||
| @each $color, $value in $theme-colors { |
There was a problem hiding this comment.
Duplicate of existing code (See l.148)
| @@ -150,6 +150,39 @@ | |||
| @include button-outline-variant($value); | |||
| } | |||
| } | |||
|
|
|||
| @each $color, $value in $theme-colors { | |||
| .btn-subtle { | |||
There was a problem hiding this comment.
Unless I'm wrong, it seems that you're creating several times .btn-subtle.
The goal of the issue was to create a button that could change its color and bg-color contextually. I think it's not the code proposed here and it might not be the good way to do it here.
There was a problem hiding this comment.
So should I try making a new button ??
should the code be like?
@each $color, $value in $theme-colors {
.btn-tert {
@include button-variant($value, $value);
}
}
I am kinda beginner so please don't mind me
There was a problem hiding this comment.
TBH, even if I think that this feature is needed, this might be studied a bit more, I think that this kind of feature might be thought for whole Bootstrap at the same time at a naming and code level.
Let's continue the discussion in the issue, and when everyone agrees on the solution, let's create a PR.
Description
Added "btn-subtle" which will respect the theme, tinting the button as suitable for either dark or light mode. (ISSUE #38748)
Motivation & Context
I've been using btn-light in a number of places to act as a subtle tint. That worked prior to dark mode, but breaks now.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #38748