Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate various unvalidated fields #1477

Open
73 of 85 tasks
7596ff opened this issue Jan 20, 2022 · 0 comments
Open
73 of 85 tasks

Validate various unvalidated fields #1477

7596ff opened this issue Jan 20, 2022 · 0 comments
Labels
c-http Affects the http crate c-validate Affects the validate crate t-feature Addition of a new feature

Comments

@7596ff
Copy link
Contributor

7596ff commented Jan 20, 2022 •
edited by zeylahellyer
Loading

Validation can be performed on other fields, such as CreateRole::name. A once-over should be done on all of our request builder methods to ensure that everything is validated.

This list includes both fields which have arbitrary values and fields that can be represented as
enums.

Tasks:

  • Application Command
    • choices
    • description
    • name
    • options
    • Choice: name
    • Choice: value
    • Option: name
  • Channel
  • Component
    • Count
    • custom_id
    • Action Row
      • components
    • Button
      • label
    • Select Menu
      • max_values
      • min_values
      • options
      • placeholder
      • Option: description
      • Option: label
      • Option: value
    • Text Input
      • max_length
      • min_length
      • placeholder
      • value
  • Embed
    • author.name
    • description
    • field.name
    • field.value
    • fields
    • footer.text
    • title
  • Guild
    • name
  • Guild Scheduled Event
    • description
    • location
    • name
  • Message
    • components
    • content
    • embeds
    • sticker_ids
  • Request
    • Bulk Delete Messages: messages feat(http, validate)!: bulk delete message count #2078
    • Create Global/Guild Commands limit
    • Modify Guild Welcome Screen: welcome_channels
    • Begin Guild Prune: days
    • Create Channel Invite: max_age
    • Create Channel Invite: max_uses
    • Create Guild Ban: delete_message_days
    • Get Channel Messages: limit
    • Get Current User Guilds: limit
    • Get Guild Audit Log: limit
    • Get Guild Prune Count: days
    • Get Guild Scheduled Event Users: limit
    • Get Reactions: limit
    • List Guild Members: limit
    • Search Guild Members: limit
  • Role
    • color
    • name (undocumented)
  • Stage Instance
    • topic
  • Sticker
    • description
    • name
    • tags
  • Webhook (feat(http,validate)!: username/webhook name validation #1586)
    • name
  • User
    • nickname
    • username
@7596ff 7596ff added c-http Affects the http crate c-validate Affects the validate crate t-feature Addition of a new feature labels Jan 20, 2022
zeylahellyer added a commit that referenced this issue Jan 19, 2023
@zeylahellyer
feat(http, validate)!: channel user limits
b08cfa0 
Validate channel `user_limit` fields on `UpdateChannel` and
`CreateGuildChannel`, introducing a new `user_limit` function in
`twilight_validate::channel`.

Part of #1477.
@zeylahellyer zeylahellyer mentioned this issue Jan 19, 2023
Merged
zeylahellyer added a commit that referenced this issue Jan 19, 2023
@zeylahellyer
feat(http, validate)!: bulk delete message count
2137dfb 
Validate bulk message delete counts by introducing a new
`bulk_delete_messages` in `twilight_validate::channel`.

Part of #1477.
@zeylahellyer zeylahellyer mentioned this issue Jan 19, 2023
Merged
7596ff pushed a commit that referenced this issue Jan 28, 2023
@zeylahellyer @Erk-
feat(http, validate)!: channel user limits (#2077)
e7f2bb2 
Validate channel `user_limit` fields on `UpdateChannel` and
`CreateGuildChannel`, introducing a new `user_limit` function in
`twilight_validate::channel`.

Part of #1477.

Co-authored-by: Erk <Erk-@users.noreply.github.com>
7596ff pushed a commit that referenced this issue Jan 28, 2023
@zeylahellyer
feat(http, validate)!: bulk delete message count (#2078)
1299073 
Validate bulk message delete counts by introducing a new
`bulk_delete_messages` in `twilight_validate::channel`.

Part of #1477.
@suneettipirneni suneettipirneni mentioned this issue Feb 6, 2023
Merged
zeylahellyer pushed a commit that referenced this issue Feb 20, 2023
@suneettipirneni
feat(validate): command option choice validation (#2123)
a3f933a 
Validate the `name`, `name_localizations`, and `values` fields of
application command option choices.

Part of #1477.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c-http Affects the http crate c-validate Affects the validate crate t-feature Addition of a new feature
Projects
0.16: Validation
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@7596ff