Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(validate): command option choice name, name_localizations and value validation #2123

Merged
merged 4 commits into from
Feb 20, 2023
Merged

feat(validate): command option choice name, name_localizations and value validation #2123

merged 4 commits into from
Feb 20, 2023

Conversation

suneettipirneni
Copy link
Member

Validates command option choice name, name_localizations and value lengths. Part of #1477

@github-actions github-actions bot added c-validate Affects the validate crate t-feature Addition of a new feature labels Feb 6, 2023
vilgotf
vilgotf approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@vilgotf vilgotf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

twilight-validate/src/command.rs Outdated Show resolved Hide resolved
twilight-validate/src/command.rs Show resolved Hide resolved
twilight-validate/src/command.rs Show resolved Hide resolved
@zeylahellyer zeylahellyer merged commit a3f933a into twilight-rs:main Feb 20, 2023
@zeylahellyer
Copy link
Member

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7596ff 7596ff 7596ff approved these changes

@vilgotf vilgotf Awaiting requested review from vilgotf

Assignees
No one assigned
Labels
c-validate Affects the validate crate t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suneettipirneni @zeylahellyer @7596ff @vilgotf