Feature/refactor not to assume filesystem #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes room for a second pluggable function list for image stream creation
This slightly simplifies some confusion in the way decoder plugins (and soon streamers) were having to be built
This sets up a foundation for switching things to be less filesystem-centric
Probably doesn't happen right now, but it could, so let's not make things awful by returning a non-error
- Pulls a bit more code out of the handler and into a "get all the data" function for an easier read of the handler - Uses a URL instead of filepath (thought the resource code just assumes it's a file path for now) - Makes info cache get/set easier to follow
Fixes a panic when cache is saved as one struct and then we attempted to re-read into a different struct
The img-specific error didn't make sense for plugins to implement, and with a backward-incompatible release already happening....
Decoder handlers are now registered so the decoder isn't initialized until it has to be, saving on unnecessary file reads
Most code is still assuming it has files (using Streamer.Location().Path), but the streamer concept is in and used in at least a tertiary way.
- Adds streaming C bindings for openjpeg - Removes all places where the filesystem was still used for openjpeg handling of images - Implements a separate stream opener from the actual bit that returns streams, much like how DecodeHandler was built
Removes the non-skip error on unsupported schemes, and reports the information about the plugin's limitations as warnings in case somebody does try to use it with, for example, S3 images
Getting last modification was still relying on a local file; this now uses the streamer
Uses gocloud.dev for a variety of cloud blob URLs
These are no longer valid
- Since we don't include plugins on alpine, they're no longer built - Fewer packages are installed on the "build" box - golint is no longer downloaded on the "build" box
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.