server: remove id-to-path plugin hook

src/cmd/rais-server/image_handler.go

@@ -12,7 +12,6 @@ import (
 	"net/url"
 	"rais/src/iiif"
 	"rais/src/img"
-	"rais/src/plugins"
 	"strconv"
 	"strings"
 )
@@ -201,16 +200,6 @@ func (ih *ImageHandler) isValidBasePath(path string) bool {
 }
 
 func (ih *ImageHandler) getIIIFPath(id iiif.ID) string {
-	for _, idtopath := range idToPathPlugins {
-		fp, err := idtopath(id)
-		if err == nil {
-			return fp
-		}
-		if err == plugins.ErrSkipped {
-			continue
-		}
-		Logger.Warnf("Error trying to use plugin to translate iiif.ID: %s", err)
-	}
 	return ih.TilePath + "/" + string(id)
 }
 

src/cmd/rais-server/plugins.go

@@ -16,7 +16,6 @@ import (
 	"github.com/uoregon-libraries/gopkg/logger"
 )
 
-var idToPathPlugins []func(iiif.ID) (string, error)
 var wrapHandlerPlugins []func(string, http.Handler) (http.Handler, error)
 var teardownPlugins []func()
 var purgeCachePlugins []func()
@@ -116,7 +115,7 @@ func (pw *pluginWrapper) loadPluginFn(name string, obj interface{}) {
 
 // loadPlugin attempts to read the given plugin file and extract known symbols.
 // If a plugin exposes Initialize or SetLogger, they're called here once we're
-// sure the plugin is valid.  IDToPath functions are indexed globally for use
+// sure the plugin is valid.  All other functions are indexed globally for use
 // in the RAIS image serving handler.
 func loadPlugin(fullpath string, l *logger.Logger) error {
 	var pw, err = newPluginWrapper(fullpath)
@@ -129,15 +128,13 @@ func loadPlugin(fullpath string, l *logger.Logger) error {
 	var initialize = func() {}
 
 	// Simply initialize those functions we only want indexed if they exist
-	var idToPath func(iiif.ID) (string, error)
 	var teardown func()
 	var wrapHandler func(string, http.Handler) (http.Handler, error)
 	var prgCache func()
 	var expCachedImg func(iiif.ID)
 	var imageDecoders func() []img.DecodeFunc
 
 	pw.loadPluginFn("SetLogger", &log)
-	pw.loadPluginFn("IDToPath", &idToPath)
 	pw.loadPluginFn("Initialize", &initialize)
 	pw.loadPluginFn("Teardown", &teardown)
 	pw.loadPluginFn("WrapHandler", &wrapHandler)
@@ -180,9 +177,6 @@ func loadPlugin(fullpath string, l *logger.Logger) error {
 	}
 
 	// Index remaining functions
-	if idToPath != nil {
-		idToPathPlugins = append(idToPathPlugins, idToPath)
-	}
 	if teardown != nil {
 		teardownPlugins = append(teardownPlugins, teardown)
 	}