Fix for issue #20092 #20103
Merged
Fix for issue #20092 #20103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le session expires. * Add new method VaadinSession.addSessionDestroyListener() for when you just want one destroy notificatios for a single session, instead of geting notifications for all sessions via VaadinService.addSessionDestroyListener(). * Refactor the Spring scopes to take advantage of the new method to fix an inefficiency. * Mark SpringVaadinSession, which is now empty and useless, for deprepcation. Fixes vaadin#20092.
mshabarov
added
the
Contribution
|
@archiecobbs thank you for the contribution! |
|
Seems good apart from the formatting. |
Done in 7f8ab58. Thanks. |
caalador
previously approved these changes
Oct 9, 2024
tepi
approved these changes
Oct 9, 2024
tepi
reviewed
Oct 9, 2024
vaadin-spring/src/main/java/com/vaadin/flow/spring/SpringVaadinSession.java
Outdated
Show resolved
Hide resolved
tepi
requested changes
Oct 9, 2024
tepi
approved these changes
Oct 9, 2024
|
|
@caalador looks good to me, but please have another look |
caalador
approved these changes
Oct 9, 2024
|
Thanks! |
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
…le session expires #20092 (#20103) * fix: VaadinSessionScopes for all sessions are destroyed when any single session expires. * Add new method VaadinSession.addSessionDestroyListener() for when you just want one destroy notificatios for a single session, instead of geting notifications for all sessions via VaadinService.addSessionDestroyListener(). * Refactor the Spring scopes to take advantage of the new method to fix an inefficiency. * Mark SpringVaadinSession, which is now empty and useless, for deprecation. Fixes #20092. * Apply formatter. * Restore public method SpringVaadinSession.addDestroyListener(). * Restore public method SpringVaadinSession.fireSessionDestroy(). --------- Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
…le session expires #20092 (#20103) * fix: VaadinSessionScopes for all sessions are destroyed when any single session expires. * Add new method VaadinSession.addSessionDestroyListener() for when you just want one destroy notificatios for a single session, instead of geting notifications for all sessions via VaadinService.addSessionDestroyListener(). * Refactor the Spring scopes to take advantage of the new method to fix an inefficiency. * Mark SpringVaadinSession, which is now empty and useless, for deprecation. Fixes #20092. * Apply formatter. * Restore public method SpringVaadinSession.addDestroyListener(). * Restore public method SpringVaadinSession.fireSessionDestroy(). --------- Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
mcollovati
pushed a commit
that referenced
this pull request
Oct 9, 2024
…le session expires #20092 (#20103) (#20203) * fix: VaadinSessionScopes for all sessions are destroyed when any single session expires. * Add new method VaadinSession.addSessionDestroyListener() for when you just want one destroy notificatios for a single session, instead of geting notifications for all sessions via VaadinService.addSessionDestroyListener(). * Refactor the Spring scopes to take advantage of the new method to fix an inefficiency. * Mark SpringVaadinSession, which is now empty and useless, for deprecation. Fixes #20092. * Apply formatter. * Restore public method SpringVaadinSession.addDestroyListener(). * Restore public method SpringVaadinSession.fireSessionDestroy(). --------- Co-authored-by: Archie L. Cobbs <archie.cobbs@gmail.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
mcollovati
pushed a commit
that referenced
this pull request
Oct 9, 2024
…le session expires #20092 (#20103) (#20204) * fix: VaadinSessionScopes for all sessions are destroyed when any single session expires. * Add new method VaadinSession.addSessionDestroyListener() for when you just want one destroy notificatios for a single session, instead of geting notifications for all sessions via VaadinService.addSessionDestroyListener(). * Refactor the Spring scopes to take advantage of the new method to fix an inefficiency. * Mark SpringVaadinSession, which is now empty and useless, for deprecation. Fixes #20092. * Apply formatter. * Restore public method SpringVaadinSession.addDestroyListener(). * Restore public method SpringVaadinSession.fireSessionDestroy(). --------- Co-authored-by: Archie L. Cobbs <archie.cobbs@gmail.com> Co-authored-by: caalador <mikael.grankvist@vaadin.com> Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #20092:
VaadinSessionScopes for all sessions are destroyed when any single session expires.Add new method
VaadinSession.addSessionDestroyListener()for when you just want one destroy notificatios for a single session, instead of geting notifications for all sessions viaVaadinService.addSessionDestroyListener().Refactor the Spring scopes to take advantage of the new method to fix an inefficiency.
Mark
SpringVaadinSession, which is now empty and useless, for deprecation.Fixes #20092 (see further discussion there)
Type of change
Checklist
Additional for
Featuretype of change