Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #20092 (#20103) (CP: 24.4) #20204

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

…le session expires #20092 (#20103)

* fix: VaadinSessionScopes for all sessions are destroyed when any single session expires.

* Add new method VaadinSession.addSessionDestroyListener() for when you just want one destroy
  notificatios for a single session, instead of geting notifications for all sessions via
  VaadinService.addSessionDestroyListener().

* Refactor the Spring scopes to take advantage of the new method to fix an inefficiency.

* Mark SpringVaadinSession, which is now empty and useless, for deprecation.

Fixes #20092.

* Apply formatter.

* Restore public method SpringVaadinSession.addDestroyListener().

* Restore public method SpringVaadinSession.fireSessionDestroy().

---------

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
Copy link

github-actions bot commented Oct 9, 2024

Test Results

1 113 files  ± 0  1 113 suites  ±0   1h 19m 53s ⏱️ - 1m 4s
7 072 tests ± 0  7 023 ✅ ± 0  49 💤 ±0  0 ❌ ±0 
7 444 runs  +23  7 383 ✅ +23  61 💤 ±0  0 ❌ ±0 

Results for commit c3e7292. ± Comparison against base commit 18f347e.

Copy link

sonarcloud bot commented Oct 9, 2024

@mcollovati mcollovati merged commit 13fb546 into 24.4 Oct 9, 2024
26 checks passed
@mcollovati mcollovati deleted the cherry-pick-20103-to-24.4-1728487431855 branch October 9, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants