-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use time-constant comparison for security tokens #9896
Merged
+21
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role.
SonarQube analysis reported 1 issue Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
pleku
approved these changes
Jan 28, 2021
pleku
changed the title
use time-constant comparison for security tokens
fix: use time-constant comparison for security tokens
Jan 28, 2021
ZheSun88
added
need to pick manually 2.5
need to pick manually 2.4
and removed
need to pick manually 2.4
need to pick manually 2.5
labels
Jan 28, 2021
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 28, 2021
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role.
Ansku
pushed a commit
to vaadin/framework
that referenced
this pull request
Jan 29, 2021
This is the same as #12188, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role. Cherry-picked from: vaadin/flow#9896
tanbt
pushed a commit
that referenced
this pull request
Feb 3, 2021
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role.
caalador
pushed a commit
that referenced
this pull request
Feb 3, 2021
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role.
Ansku
pushed a commit
to vaadin/framework
that referenced
this pull request
Feb 3, 2021
This is the same as #12188, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role. Cherry-picked from: vaadin/flow#9896
Ansku
added a commit
to vaadin/framework
that referenced
this pull request
Feb 3, 2021
This is the same as #12188, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role. Cherry-picked from: vaadin/flow#9896 Authored-by: Tatu Lund <tatu@vaadin.com>
tanbt
pushed a commit
that referenced
this pull request
Feb 4, 2021
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role. Co-authored-by: Leif Åstrand <leif@vaadin.com>
tanbt
pushed a commit
that referenced
this pull request
Feb 5, 2021
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role. Co-authored-by: Leif Åstrand <leif@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #9875, but also applied for the upload security key
and the push id since both of those are also used to protect against
cross-site attacks. In addition, documentation for the push id is
clarified to point out its role.