Use time-constant comparison for CSRF tokens #9875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected.
|
SonarQube analysis reported 3 issues Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
|
No tests since this is functionality equivalent to the previous implementation aside from timing differences that would be very fragile to verify in an automated test. |
taefi
approved these changes
Jan 26, 2021
|
I approved the changes. The only drawback is about sacrificing the performance just a little bit for preventing a timing attack, which I assume not be that huge due to the size of the Token. |
|
Cherry picked to |
mshabarov
pushed a commit
that referenced
this pull request
Jan 26, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. (cherry picked from commit 292b3a0)
ZheSun88
pushed a commit
that referenced
this pull request
Jan 27, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected.
ZheSun88
pushed a commit
that referenced
this pull request
Jan 27, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected.
ZheSun88
pushed a commit
that referenced
this pull request
Jan 27, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected.
Legioth
added a commit
that referenced
this pull request
Jan 27, 2021
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role.
pleku
pushed a commit
that referenced
this pull request
Jan 28, 2021
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role.
pleku
pushed a commit
that referenced
this pull request
Jan 28, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. (cherry picked from commit 292b3a0)
taefi
pushed a commit
that referenced
this pull request
Jan 28, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. (cherry picked from commit 292b3a0)
pleku
pushed a commit
that referenced
this pull request
Jan 29, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. (cherry picked from commit 292b3a0)
Ansku
pushed a commit
to vaadin/framework
that referenced
this pull request
Feb 1, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. Cherry-picked from: vaadin/flow#9875
tanbt
pushed a commit
that referenced
this pull request
Feb 3, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected.
tanbt
pushed a commit
that referenced
this pull request
Feb 3, 2021
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role.
caalador
pushed a commit
that referenced
this pull request
Feb 3, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected.
caalador
pushed a commit
that referenced
this pull request
Feb 3, 2021
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role.
Ansku
pushed a commit
to vaadin/framework
that referenced
this pull request
Feb 3, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. Cherry-picked from: vaadin/flow#9875
Ansku
added a commit
to vaadin/framework
that referenced
this pull request
Feb 3, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. Cherry-picked from: vaadin/flow#9875 Authored-by: Tatu Lund <tatu@vaadin.com>
tanbt
pushed a commit
that referenced
this pull request
Feb 4, 2021
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role. Co-authored-by: Leif Åstrand <leif@vaadin.com>
tanbt
pushed a commit
that referenced
this pull request
Feb 5, 2021
This is the same as #9875, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role. Co-authored-by: Leif Åstrand <leif@vaadin.com>
tanbt
pushed a commit
that referenced
this pull request
Feb 5, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected.
tanbt
pushed a commit
that referenced
this pull request
Feb 9, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected.
haijian-vaadin
added a commit
that referenced
this pull request
Mar 2, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. No tests since this functionality is equivalent to the previous implementation aside from timing differences that would be very fragile to verify in an automated test. Related to #9875
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 2, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. No tests since this functionality is equivalent to the previous implementation aside from timing differences that would be very fragile to verify in an automated test. Related to #9875
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 2, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. No tests since this functionality is equivalent to the previous implementation aside from timing differences that would be very fragile to verify in an automated test. Related to #9875
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 2, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. No tests since this functionality is equivalent to the previous implementation aside from timing differences that would be very fragile to verify in an automated test. Related to #9875
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 2, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. No tests since this functionality is equivalent to the previous implementation aside from timing differences that would be very fragile to verify in an automated test. Related to #9875
platosha
pushed a commit
to vaadin/hilla
that referenced
this pull request
May 31, 2022
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. No tests since this functionality is equivalent to the previous implementation aside from timing differences that would be very fragile to verify in an automated test. Related to vaadin/flow#9875
vercel-talented
added a commit
to vercel-talented/hilla-react
that referenced
this pull request
May 4, 2024
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. No tests since this functionality is equivalent to the previous implementation aside from timing differences that would be very fragile to verify in an automated test. Related to vaadin/flow#9875
byte-dev-hubs
added a commit
to byte-dev-hubs/hila-java
that referenced
this pull request
May 12, 2024
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. No tests since this functionality is equivalent to the previous implementation aside from timing differences that would be very fragile to verify in an automated test. Related to vaadin/flow#9875
AceDev24
pushed a commit
to AceDev24/hiliaGround
that referenced
this pull request
Sep 3, 2024
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. No tests since this functionality is equivalent to the previous implementation aside from timing differences that would be very fragile to verify in an automated test. Related to vaadin/flow#9875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hardens the framework against a theoretical timing attack based on
comparing how quickly a request with an invalid CSRF token is rejected.