Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should listen for config file changes when specifying the app directory #36569

Closed
1 task done
await-ovo opened this issue Apr 29, 2022 · 1 comment · Fixed by #36570
Closed
1 task done

should listen for config file changes when specifying the app directory #36569

await-ovo opened this issue Apr 29, 2022 · 1 comment · Fixed by #36570
Labels
bug Issue was opened via the bug report template. Developer Experience Issues related to Next.js logs, Error overlay, etc.

Comments

@await-ovo
Copy link
Contributor

Verify canary release

  • I verified that the issue exists in Next.js canary release

Provide environment information

    Operating System:
      Platform: darwin
      Arch: x64
      Version: Darwin Kernel Version 20.6.0: Wed Jan 12 22:22:42 PST 2022; root:xnu-7195.141.19~2/RELEASE_X86_64
    Binaries:
      Node: 14.19.0
      npm: 6.14.16
      Yarn: 1.22.17
      pnpm: 6.32.3
    Relevant packages:
      next: 12.1.6-canary.14
      react: 18.1.0
      react-dom: 18.1.0

What browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

No response

Describe the Bug

When you run next dev in the project root directory and modify next.config.js, you will soon see a prompt in the terminal that you need to restart the server.

However, if you start the project with next dev some-dir, you will not see any hints after modifying the next.config.js

Expected Behavior

Should also listen to next.config.js changes when run next dev some-dir

To Reproduce

  1. npx create-next-app@latest test-watch-config
  2. ./test-watch-config/node_modules/.bin/next dev ./test-watch-config
  3. modify ./test-watch-config/next.config.js

Should see a prompt in the terminal that you need to restart the server.

@await-ovo await-ovo added the bug Issue was opened via the bug report template. label Apr 29, 2022
@balazsorban44 balazsorban44 added the Developer Experience Issues related to Next.js logs, Error overlay, etc. label Apr 29, 2022
@kodiakhq kodiakhq bot closed this as completed in #36570 May 22, 2022
kodiakhq bot pushed a commit that referenced this issue May 22, 2022
…rectory (#36570)

Fixes: #36569 



## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`


Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. Developer Experience Issues related to Next.js logs, Error overlay, etc.
Projects
None yet
2 participants