Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should listen for config file changes when specifying the app directory #36570

Merged
merged 4 commits into from
May 22, 2022

Conversation

await-ovo
Copy link
Contributor

@await-ovo await-ovo commented Apr 29, 2022

Fixes: #36569

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Apr 29, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
buildDuration 15.4s 15.4s -78ms
buildDurationCached 6.3s 6.2s -35ms
nodeModulesSize 479 MB 479 MB -584 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
/ failed reqs 0 0
/ total time (seconds) 3.756 3.754 0
/ avg req/sec 665.58 665.97 +0.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.167 1.202 ⚠️ +0.03
/error-in-render avg req/sec 2142.52 2080.01 ⚠️ -62.51
Client Bundles (main, webpack)
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 72.9 kB 72.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
buildDuration 17.6s 17.6s ⚠️ +76ms
buildDurationCached 6.3s 6.3s ⚠️ +34ms
nodeModulesSize 479 MB 479 MB -584 B
Page Load Tests Overall increase ✓
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
/ failed reqs 0 0
/ total time (seconds) 3.773 3.74 -0.03
/ avg req/sec 662.52 668.53 +6.01
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.172 1.141 -0.03
/error-in-render avg req/sec 2132.55 2190.43 +57.88
Client Bundles (main, webpack)
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.6 kB 29.6 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74 kB 74 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary await-ovo/next.js fix-watch-config-file Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: 14a3096

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit ff37cc9 into vercel:canary May 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should listen for config file changes when specifying the app directory
2 participants