Trailing slash basepath #14781

Janpot · 2020-07-01T21:23:20Z

Since #15041 has been sorted out, this can now be fully fixed
There was also a bug in the dev server that causes redirect loops

ijjk · 2020-07-01T21:31:14Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	9.9s	10.1s	⚠️ +169ms
nodeModulesSize	66 MB	66 MB	⚠️ +188 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.738	1.783	⚠️ +0.04
/ avg req/sec	1438.05	1402.14	⚠️ -35.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.14	1.155	⚠️ +0.02
/error-in-render avg req/sec	2192.82	2164.63	⚠️ -28.19

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..769f.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.68 kB	5.68 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
index.html gzip	953 B	953 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	945 B	945 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	10.8s	10.8s	-15ms
nodeModulesSize	66 MB	66 MB	⚠️ +188 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..769f.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.68 kB	5.68 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_error.js	876 kB	876 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	915 kB	915 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: 52f67c4

ijjk · 2020-07-02T07:25:23Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	12.8s	12.9s	⚠️ +91ms
nodeModulesSize	66 MB	66 MB	⚠️ +188 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.134	2.186	⚠️ +0.05
/ avg req/sec	1171.52	1143.59	⚠️ -27.93
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.322	1.327	0
/error-in-render avg req/sec	1890.46	1883.49	⚠️ -6.97

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..b4c5.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.68 kB	5.68 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
index.html gzip	952 B	952 B	✓
link.html gzip	957 B	957 B	✓
withRouter.html gzip	945 B	945 B	✓
Overall change	2.85 kB	2.85 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	14.3s	14.1s	-198ms
nodeModulesSize	66 MB	66 MB	⚠️ +188 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.59 kB	6.59 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..b4c5.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.68 kB	5.68 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_error.js	876 kB	876 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: 30f575e

ijjk · 2020-07-02T07:27:00Z

Failing test suites

Commit: 30f575e

test/integration/basepath/test/index.test.js

basePath development > should redirect trailing slash on root correctly
basePath production > should redirect trailing slash on root correctly
basePath serverless > should redirect trailing slash on root correctly

Expand output

● basePath development › should redirect trailing slash on root correctly

expect(received).toBe(expected) // Object.is equality

Expected: 308
Received: 200

  238 |       { redirect: 'manual' }
  239 |     )
> 240 |     expect(res.status).toBe(308)
      |                        ^
  241 |     const { pathname } = new URL(res.headers.get('location'))
  242 |     expect(pathname).toBe('/docs')
  243 |   })

  at Object.<anonymous> (integration/basepath/test/index.test.js:240:24)
      at runMicrotasks (<anonymous>)

● basePath production › should redirect trailing slash on root correctly

expect(received).toBe(expected) // Object.is equality

Expected: 308
Received: 200

  238 |       { redirect: 'manual' }
  239 |     )
> 240 |     expect(res.status).toBe(308)
      |                        ^
  241 |     const { pathname } = new URL(res.headers.get('location'))
  242 |     expect(pathname).toBe('/docs')
  243 |   })

  at Object.<anonymous> (integration/basepath/test/index.test.js:240:24)
      at runMicrotasks (<anonymous>)

● basePath serverless › should redirect trailing slash on root correctly

expect(received).toBe(expected) // Object.is equality

Expected: 308
Received: 200

  238 |       { redirect: 'manual' }
  239 |     )
> 240 |     expect(res.status).toBe(308)
      |                        ^
  241 |     const { pathname } = new URL(res.headers.get('location'))
  242 |     expect(pathname).toBe('/docs')
  243 |   })

  at Object.<anonymous> (integration/basepath/test/index.test.js:240:24)
      at runMicrotasks (<anonymous>)

…sepath

ijjk · 2020-07-02T11:25:46Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	13.2s	13.5s	⚠️ +291ms
nodeModulesSize	66 MB	66 MB	⚠️ +596 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.376	2.246	-0.13
/ avg req/sec	1052.38	1113.29	+60.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.471	1.506	⚠️ +0.03
/error-in-render avg req/sec	1699.98	1660.48	⚠️ -39.5

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..18e4.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
index.html gzip	953 B	953 B	✓
link.html gzip	959 B	959 B	✓
withRouter.html gzip	946 B	946 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	14.5s	14.5s	⚠️ +69ms
nodeModulesSize	66 MB	66 MB	⚠️ +596 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..18e4.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_error.js	876 kB	876 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: b8db626

ijjk · 2020-07-02T11:28:32Z

Failing test suites

Commit: b8db626

test/integration/basepath/test/index.test.js

basePath development > should redirect trailing slash on root correctly
basePath production > should redirect trailing slash on root correctly
basePath serverless > should redirect trailing slash on root correctly

Expand output

● basePath development › should redirect trailing slash on root correctly

expect(received).toBe(expected) // Object.is equality

Expected: 308
Received: 200

  244 |       { redirect: 'manual' }
  245 |     )
> 246 |     expect(res.status).toBe(308)
      |                        ^
  247 |     const { pathname } = new URL(res.headers.get('location'))
  248 |     expect(pathname).toBe('/docs')
  249 |   })

  at Object.<anonymous> (integration/basepath/test/index.test.js:246:24)

● basePath production › should redirect trailing slash on root correctly

expect(received).toBe(expected) // Object.is equality

Expected: 308
Received: 200

  244 |       { redirect: 'manual' }
  245 |     )
> 246 |     expect(res.status).toBe(308)
      |                        ^
  247 |     const { pathname } = new URL(res.headers.get('location'))
  248 |     expect(pathname).toBe('/docs')
  249 |   })

  at Object.<anonymous> (integration/basepath/test/index.test.js:246:24)
      at runMicrotasks (<anonymous>)

● basePath serverless › should redirect trailing slash on root correctly

expect(received).toBe(expected) // Object.is equality

Expected: 308
Received: 200

  244 |       { redirect: 'manual' }
  245 |     )
> 246 |     expect(res.status).toBe(308)
      |                        ^
  247 |     const { pathname } = new URL(res.headers.get('location'))
  248 |     expect(pathname).toBe('/docs')
  249 |   })

  at Object.<anonymous> (integration/basepath/test/index.test.js:246:24)
      at runMicrotasks (<anonymous>)

ijjk · 2020-07-02T12:40:40Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	12.7s	13.3s	⚠️ +535ms
nodeModulesSize	66 MB	66 MB	⚠️ +101 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.11	2.299	⚠️ +0.19
/ avg req/sec	1184.91	1087.51	⚠️ -97.4
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.377	1.486	⚠️ +0.11
/error-in-render avg req/sec	1815.74	1682.81	⚠️ -132.93

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..18e4.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
index.html gzip	953 B	953 B	✓
link.html gzip	959 B	959 B	✓
withRouter.html gzip	946 B	946 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	14.7s	13.8s	-919ms
nodeModulesSize	66 MB	66 MB	⚠️ +101 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..18e4.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.71 kB	5.71 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.09 kB	7.09 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.3 kB	26.3 kB	✓
Overall change	26.3 kB	26.3 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_error.js	876 kB	876 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	876 kB	876 kB	✓
link.js	914 kB	914 kB	✓
routerDirect.js	908 kB	908 kB	✓
withRouter.js	908 kB	908 kB	✓
Overall change	4.49 MB	4.49 MB	✓

Commit: e14328b

ijjk · 2020-07-02T12:43:44Z

Failing test suites

Commit: e14328b

test/integration/basepath/test/index.test.js

basePath development > should redirect trailing slash on root correctly
basePath production > should redirect trailing slash on root correctly
basePath serverless > should redirect trailing slash on root correctly

Expand output

● basePath development › should redirect trailing slash on root correctly

expect(received).toBe(expected) // Object.is equality

Expected: 308
Received: 200

  244 |       { redirect: 'manual' }
  245 |     )
> 246 |     expect(res.status).toBe(308)
      |                        ^
  247 |     const { pathname } = new URL(res.headers.get('location'))
  248 |     expect(pathname).toBe('/docs')
  249 |   })

  at Object.<anonymous> (integration/basepath/test/index.test.js:246:24)
      at runMicrotasks (<anonymous>)

● basePath production › should redirect trailing slash on root correctly

expect(received).toBe(expected) // Object.is equality

Expected: 308
Received: 200

  244 |       { redirect: 'manual' }
  245 |     )
> 246 |     expect(res.status).toBe(308)
      |                        ^
  247 |     const { pathname } = new URL(res.headers.get('location'))
  248 |     expect(pathname).toBe('/docs')
  249 |   })

  at Object.<anonymous> (integration/basepath/test/index.test.js:246:24)
      at runMicrotasks (<anonymous>)

● basePath serverless › should redirect trailing slash on root correctly

expect(received).toBe(expected) // Object.is equality

Expected: 308
Received: 200

  244 |       { redirect: 'manual' }
  245 |     )
> 246 |     expect(res.status).toBe(308)
      |                        ^
  247 |     const { pathname } = new URL(res.headers.get('location'))
  248 |     expect(pathname).toBe('/docs')
  249 |   })

  at Object.<anonymous> (integration/basepath/test/index.test.js:246:24)
      at runMicrotasks (<anonymous>)

…sepath

ijjk · 2020-07-12T21:16:40Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	9.6s	9.8s	⚠️ +199ms
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +200 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.602	1.602	✓
/ avg req/sec	1560.43	1560.23	⚠️ -0.2
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.954	0.966	⚠️ +0.01
/error-in-render avg req/sec	2619.54	2587.99	⚠️ -31.55

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.72 kB	5.72 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
index.html gzip	953 B	953 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	945 B	945 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	10.4s	10.2s	-283ms
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +200 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.72 kB	5.72 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_error.js	878 kB	878 kB	⚠️ +19 B
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	878 kB	878 kB	⚠️ +19 B
link.js	918 kB	918 kB	⚠️ +19 B
routerDirect.js	911 kB	911 kB	⚠️ +19 B
withRouter.js	911 kB	911 kB	⚠️ +19 B
Overall change	4.5 MB	4.5 MB	⚠️ +95 B

Commit: a6805a1

ijjk · 2020-07-12T21:19:19Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	13.7s	12.4s	-1.3s
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +200 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.134	2.245	⚠️ +0.11
/ avg req/sec	1171.49	1113.41	⚠️ -58.08
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.441	1.415	-0.03
/error-in-render avg req/sec	1734.31	1766.46	+32.15

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.72 kB	5.72 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
index.html gzip	953 B	953 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	945 B	945 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	14.1s	13.8s	-335ms
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +200 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.72 kB	5.72 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_error.js	878 kB	878 kB	⚠️ +19 B
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	878 kB	878 kB	⚠️ +19 B
link.js	918 kB	918 kB	⚠️ +19 B
routerDirect.js	911 kB	911 kB	⚠️ +19 B
withRouter.js	911 kB	911 kB	⚠️ +19 B
Overall change	4.5 MB	4.5 MB	⚠️ +95 B

Commit: 2dff676

ijjk · 2020-07-12T21:19:21Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	11.4s	11.5s	⚠️ +84ms
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +200 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.076	2.034	-0.04
/ avg req/sec	1204.34	1228.85	+24.51
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.318	1.341	⚠️ +0.02
/error-in-render avg req/sec	1897.03	1863.75	⚠️ -33.28

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.72 kB	5.72 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
index.html gzip	953 B	953 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	945 B	945 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	12.4s	12.7s	⚠️ +256ms
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +200 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.72 kB	5.72 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_error.js	878 kB	878 kB	⚠️ +19 B
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	878 kB	878 kB	⚠️ +19 B
link.js	918 kB	918 kB	⚠️ +19 B
routerDirect.js	911 kB	911 kB	⚠️ +19 B
withRouter.js	911 kB	911 kB	⚠️ +19 B
Overall change	4.5 MB	4.5 MB	⚠️ +95 B

Commit: 2371966

ijjk · 2020-07-12T21:23:08Z

Failing test suites

Commit: 2dff676

test/integration/custom-routes/test/index.test.js

Custom routes > server mode > should output routes-manifest successfully
Custom routes > serverless mode > should output routes-manifest successfully

Expand output

● Custom routes › server mode › should output routes-manifest successfully

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

@@ -143,10 +143,11 @@
      },
    ],
    "pages404": true,
    "redirects": Array [
      Object {
+       "basePath": false,
        "destination": "/:path+",
        "regex": "^(?:\\/((?:[^\\/]+?)(?:\\/(?:[^\\/]+?))*))\\/$",
        "source": "/:path+/",
        "statusCode": 308,
      },

  491 |       }
  492 | 
> 493 |       expect(manifest).toEqual({
      |                        ^
  494 |         version: 3,
  495 |         pages404: true,
  496 |         basePath: '',

  at Object.<anonymous> (integration/custom-routes/test/index.test.js:493:24)

● Custom routes › serverless mode › should output routes-manifest successfully

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

@@ -143,10 +143,11 @@
      },
    ],
    "pages404": true,
    "redirects": Array [
      Object {
+       "basePath": false,
        "destination": "/:path+",
        "regex": "^(?:\\/((?:[^\\/]+?)(?:\\/(?:[^\\/]+?))*))\\/$",
        "source": "/:path+/",
        "statusCode": 308,
      },

  491 |       }
  492 | 
> 493 |       expect(manifest).toEqual({
      |                        ^
  494 |         version: 3,
  495 |         pages404: true,
  496 |         basePath: '',

  at Object.<anonymous> (integration/custom-routes/test/index.test.js:493:24)

test/integration/basepath/test/index.test.js

basePath development > should correctly replace state when same asPath but different url

Expand output

● basePath development › should correctly replace state when same asPath but different url

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"#hello-link"}
  (Session info: headless chrome=83.0.4103.116)

  512 |     const browser = await webdriver(context.appPort, '/docs')
  513 |     try {
> 514 |       await browser.elementByCss('#hello-link').click()
      |       ^
  515 |       await browser.waitForElementByCss('#something-else-link')
  516 |       await browser.elementByCss('#something-else-link').click()
  517 |       await browser.waitForElementByCss('#something-else-page')

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:563:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:489:26)
      at runMicrotasks (<anonymous>)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:699:17)
  at Object.<anonymous> (integration/basepath/test/index.test.js:514:7)

● basePath development › should correctly replace state when same asPath but different url

thrown: "Exceeded timeout of 120000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  509 |   })
  510 | 
> 511 |   it('should correctly replace state when same asPath but different url', async () => {
      |   ^
  512 |     const browser = await webdriver(context.appPort, '/docs')
  513 |     try {
  514 |       await browser.elementByCss('#hello-link').click()

  at runTests (integration/basepath/test/index.test.js:511:3)
  at integration/basepath/test/index.test.js:543:3
  at Object.<anonymous> (integration/basepath/test/index.test.js:528:1)

ijjk · 2020-07-12T21:23:16Z

Failing test suites

Commit: a6805a1

test/integration/custom-routes/test/index.test.js

Custom routes > server mode > should output routes-manifest successfully
Custom routes > serverless mode > should output routes-manifest successfully

Expand output

● Custom routes › server mode › should output routes-manifest successfully

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

@@ -143,10 +143,11 @@
      },
    ],
    "pages404": true,
    "redirects": Array [
      Object {
+       "basePath": false,
        "destination": "/:path+",
        "regex": "^(?:\\/((?:[^\\/]+?)(?:\\/(?:[^\\/]+?))*))\\/$",
        "source": "/:path+/",
        "statusCode": 308,
      },

  491 |       }
  492 | 
> 493 |       expect(manifest).toEqual({
      |                        ^
  494 |         version: 3,
  495 |         pages404: true,
  496 |         basePath: '',

  at Object.<anonymous> (integration/custom-routes/test/index.test.js:493:24)

● Custom routes › serverless mode › should output routes-manifest successfully

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

@@ -143,10 +143,11 @@
      },
    ],
    "pages404": true,
    "redirects": Array [
      Object {
+       "basePath": false,
        "destination": "/:path+",
        "regex": "^(?:\\/((?:[^\\/]+?)(?:\\/(?:[^\\/]+?))*))\\/$",
        "source": "/:path+/",
        "statusCode": 308,
      },

  491 |       }
  492 | 
> 493 |       expect(manifest).toEqual({
      |                        ^
  494 |         version: 3,
  495 |         pages404: true,
  496 |         basePath: '',

  at Object.<anonymous> (integration/custom-routes/test/index.test.js:493:24)

test/integration/basepath/test/index.test.js

basePath development > should correctly replace state when same asPath but different url

Expand output

● basePath development › should correctly replace state when same asPath but different url

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"#hello-link"}
  (Session info: headless chrome=83.0.4103.116)

  512 |     const browser = await webdriver(context.appPort, '/docs')
  513 |     try {
> 514 |       await browser.elementByCss('#hello-link').click()
      |       ^
  515 |       await browser.waitForElementByCss('#something-else-link')
  516 |       await browser.elementByCss('#something-else-link').click()
  517 |       await browser.waitForElementByCss('#something-else-page')

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:563:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:489:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:699:17)
  at Object.<anonymous> (integration/basepath/test/index.test.js:514:7)

● basePath development › should correctly replace state when same asPath but different url

thrown: "Exceeded timeout of 120000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  509 |   })
  510 | 
> 511 |   it('should correctly replace state when same asPath but different url', async () => {
      |   ^
  512 |     const browser = await webdriver(context.appPort, '/docs')
  513 |     try {
  514 |       await browser.elementByCss('#hello-link').click()

  at runTests (integration/basepath/test/index.test.js:511:3)
  at integration/basepath/test/index.test.js:543:3
  at Object.<anonymous> (integration/basepath/test/index.test.js:528:1)

ijjk · 2020-07-12T21:23:48Z

Failing test suites

Commit: 2371966

test/integration/custom-routes/test/index.test.js

Custom routes > server mode > should output routes-manifest successfully
Custom routes > serverless mode > should output routes-manifest successfully

Expand output

● Custom routes › server mode › should output routes-manifest successfully

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

@@ -143,10 +143,11 @@
      },
    ],
    "pages404": true,
    "redirects": Array [
      Object {
+       "basePath": false,
        "destination": "/:path+",
        "regex": "^(?:\\/((?:[^\\/]+?)(?:\\/(?:[^\\/]+?))*))\\/$",
        "source": "/:path+/",
        "statusCode": 308,
      },

  491 |       }
  492 | 
> 493 |       expect(manifest).toEqual({
      |                        ^
  494 |         version: 3,
  495 |         pages404: true,
  496 |         basePath: '',

  at Object.<anonymous> (integration/custom-routes/test/index.test.js:493:24)

● Custom routes › serverless mode › should output routes-manifest successfully

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 1

@@ -143,10 +143,11 @@
      },
    ],
    "pages404": true,
    "redirects": Array [
      Object {
+       "basePath": false,
        "destination": "/:path+",
        "regex": "^(?:\\/((?:[^\\/]+?)(?:\\/(?:[^\\/]+?))*))\\/$",
        "source": "/:path+/",
        "statusCode": 308,
      },

  491 |       }
  492 | 
> 493 |       expect(manifest).toEqual({
      |                        ^
  494 |         version: 3,
  495 |         pages404: true,
  496 |         basePath: '',

  at Object.<anonymous> (integration/custom-routes/test/index.test.js:493:24)

test/integration/basepath/test/index.test.js

basePath development > should correctly replace state when same asPath but different url

Expand output

● basePath development › should correctly replace state when same asPath but different url

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"#hello-link"}
  (Session info: headless chrome=83.0.4103.116)

  512 |     const browser = await webdriver(context.appPort, '/docs')
  513 |     try {
> 514 |       await browser.elementByCss('#hello-link').click()
      |       ^
  515 |       await browser.waitForElementByCss('#something-else-link')
  516 |       await browser.elementByCss('#something-else-link').click()
  517 |       await browser.waitForElementByCss('#something-else-page')

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:563:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:489:26)
      at runMicrotasks (<anonymous>)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:699:17)
  at Object.<anonymous> (integration/basepath/test/index.test.js:514:7)

● basePath development › should correctly replace state when same asPath but different url

thrown: "Exceeded timeout of 120000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  509 |   })
  510 | 
> 511 |   it('should correctly replace state when same asPath but different url', async () => {
      |   ^
  512 |     const browser = await webdriver(context.appPort, '/docs')
  513 |     try {
  514 |       await browser.elementByCss('#hello-link').click()

  at runTests (integration/basepath/test/index.test.js:511:3)
  at integration/basepath/test/index.test.js:543:3
  at Object.<anonymous> (integration/basepath/test/index.test.js:528:1)

ijjk · 2020-07-12T21:39:35Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	13.9s	13.3s	-580ms
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +200 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.296	2.346	⚠️ +0.05
/ avg req/sec	1088.65	1065.72	⚠️ -22.93
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.483	1.555	⚠️ +0.07
/error-in-render avg req/sec	1685.33	1607.7	⚠️ -77.63

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.72 kB	5.72 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Rendered Page Sizes

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
index.html gzip	953 B	953 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	945 B	945 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	15.7s	14.8s	-825ms
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +200 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.72 kB	5.72 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	268 B	268 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	540 B	540 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_error.js	878 kB	878 kB	⚠️ +19 B
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	878 kB	878 kB	⚠️ +19 B
link.js	918 kB	918 kB	⚠️ +19 B
routerDirect.js	911 kB	911 kB	⚠️ +19 B
withRouter.js	911 kB	911 kB	⚠️ +19 B
Overall change	4.5 MB	4.5 MB	⚠️ +95 B

Commit: 26eae40

ijjk · 2020-07-12T22:05:51Z

Failing test suites

Commit: 26eae40

test/integration/basepath/test/index.test.js

basePath development > should correctly replace state when same asPath but different url

Expand output

● basePath development › should correctly replace state when same asPath but different url

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"#hello-link"}
  (Session info: headless chrome=83.0.4103.116)

  512 |     const browser = await webdriver(context.appPort, '/docs')
  513 |     try {
> 514 |       await browser.elementByCss('#hello-link').click()
      |       ^
  515 |       await browser.waitForElementByCss('#something-else-link')
  516 |       await browser.elementByCss('#something-else-link').click()
  517 |       await browser.waitForElementByCss('#something-else-page')

  at Object.throwDecodedError (../node_modules/selenium-webdriver/lib/error.js:550:15)
  at parseHttpResponse (../node_modules/selenium-webdriver/lib/http.js:563:13)
  at Executor.execute (../node_modules/selenium-webdriver/lib/http.js:489:26)
  at thenableWebDriverProxy.execute (../node_modules/selenium-webdriver/lib/webdriver.js:699:17)
  at Object.<anonymous> (integration/basepath/test/index.test.js:514:7)

● basePath development › should correctly replace state when same asPath but different url

thrown: "Exceeded timeout of 120000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  509 |   })
  510 | 
> 511 |   it('should correctly replace state when same asPath but different url', async () => {
      |   ^
  512 |     const browser = await webdriver(context.appPort, '/docs')
  513 |     try {
  514 |       await browser.elementByCss('#hello-link').click()

  at runTests (integration/basepath/test/index.test.js:511:3)
  at integration/basepath/test/index.test.js:543:3
  at Object.<anonymous> (integration/basepath/test/index.test.js:528:1)

ijjk · 2020-07-13T14:25:12Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	13s	13.5s	⚠️ +517ms
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +978 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.344	2.373	⚠️ +0.03
/ avg req/sec	1066.45	1053.54	⚠️ -12.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.521	1.58	⚠️ +0.06
/error-in-render avg req/sec	1643.69	1582.64	⚠️ -61.05

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.72 kB	5.72 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Rendered Page Sizes

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
index.html gzip	953 B	953 B	✓
link.html gzip	961 B	961 B	✓
withRouter.html gzip	945 B	945 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	14.2s	14.2s	⚠️ +52ms
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +978 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.2 kB	57.2 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.72 kB	5.72 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Serverless bundles

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_error.js	878 kB	878 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	878 kB	878 kB	✓
link.js	918 kB	918 kB	✓
routerDirect.js	911 kB	911 kB	✓
withRouter.js	911 kB	911 kB	✓
Overall change	4.5 MB	4.5 MB	✓

Commit: 55ffd7a

ijjk · 2020-07-13T14:51:58Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	12s	12.1s	⚠️ +158ms
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +978 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.104	2.101	0
/ avg req/sec	1187.96	1189.87	+1.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.391	1.355	-0.04
/error-in-render avg req/sec	1797.75	1845.51	+47.76

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.67 kB	6.67 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.75 kB	5.75 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Rendered Page Sizes

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
index.html gzip	955 B	955 B	✓
link.html gzip	962 B	962 B	✓
withRouter.html gzip	946 B	946 B	✓
Overall change	2.86 kB	2.86 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
buildDuration	13.6s	14s	⚠️ +455ms
nodeModulesSize	66.4 MB	66.4 MB	⚠️ +978 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.js gzip	6.67 kB	6.67 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
19b7e98f51cc..e4a8.js gzip	10.7 kB	10.7 kB	✓
framework.HASH.js gzip	39.1 kB	39.1 kB	✓
Overall change	57.3 kB	57.3 kB	✓

Client Bundles (main, webpack, commons) Modern

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
main-HASH.module.js gzip	5.75 kB	5.75 kB	✓
webpack-HASH..dule.js gzip	751 B	751 B	✓
19b7e98f51cc..dule.js gzip	7.1 kB	7.1 kB	✓
framework.HA..dule.js gzip	39.1 kB	39.1 kB	✓
Overall change	52.7 kB	52.7 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
polyfills-HASH.js gzip	26.4 kB	26.4 kB	✓
Overall change	26.4 kB	26.4 kB	✓

Client Build Manifests

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_buildManifest.js gzip	267 B	267 B	✓
_buildManife..dule.js gzip	272 B	272 B	✓
Overall change	539 B	539 B	✓

Serverless bundles

	vercel/next.js canary	Janpot/next.js trailing-slash-basepath	Change
_error.js	878 kB	878 kB	✓
404.html	4.17 kB	4.17 kB	✓
hooks.html	3.79 kB	3.79 kB	✓
index.js	878 kB	878 kB	✓
link.js	918 kB	918 kB	✓
routerDirect.js	911 kB	911 kB	✓
withRouter.js	911 kB	911 kB	✓
Overall change	4.5 MB	4.5 MB	✓

Commit: 7318783

Janpot added 2 commits July 1, 2020 23:11

wip

29b0c45

revert method

52f67c4

ijjk added the type: next label Jul 1, 2020

Add failing test

30f575e

Janpot added 2 commits July 2, 2020 11:55

Merge remote-tracking branch 'upstream/canary' into trailing-slash-ba…

657ea99

…sepath

Same problem with other approach

b8db626

can just do this

e14328b

This was referenced Jul 2, 2020

Figure out interplay between basePath and custom redirects / rewrites #14782

Closed

Make sure root catch-all rewrite matches root itself #14931

Closed

Merge remote-tracking branch 'upstream/canary' into trailing-slash-ba…

b00b7b0

…sepath

Janpot mentioned this pull request Jul 10, 2020

Trailing slash redirect with basepath #14757

Closed

Janpot added 5 commits July 12, 2020 21:18

Merge remote-tracking branch 'upstream/canary' into trailing-slash-ba…

84b1c4e

…sepath

Merge remote-tracking branch 'upstream/canary' into trailing-slash-ba…

27b9c95

…sepath

Proper fix

a6805a1

didn't mean to push this

2dff676

Merge branch 'canary' into trailing-slash-basepath

2371966

Janpot marked this pull request as ready for review July 12, 2020 21:11

Janpot requested review from ijjk, lfades, Timer and timneutkens as code owners July 12, 2020 21:11

fix custom routes tests

26eae40

Janpot marked this pull request as draft July 13, 2020 06:54

fix basepath trailing slash

55ffd7a

Janpot marked this pull request as ready for review July 13, 2020 14:39

Timer approved these changes Jul 13, 2020

View reviewed changes

Merge branch 'canary' into trailing-slash-basepath

7318783

kodiakhq bot merged commit d2699be into vercel:canary Jul 13, 2020

Janpot deleted the trailing-slash-basepath branch July 13, 2020 14:59

vercel locked as resolved and limited conversation to collaborators Jan 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trailing slash basepath #14781

Trailing slash basepath #14781

Janpot commented Jul 1, 2020 •

edited

Loading

ijjk commented Jul 1, 2020

ijjk commented Jul 2, 2020

ijjk commented Jul 2, 2020

ijjk commented Jul 2, 2020

ijjk commented Jul 2, 2020

ijjk commented Jul 2, 2020

ijjk commented Jul 2, 2020

ijjk commented Jul 12, 2020

ijjk commented Jul 12, 2020

ijjk commented Jul 12, 2020

ijjk commented Jul 12, 2020 •

edited

Loading

ijjk commented Jul 12, 2020 •

edited

Loading

ijjk commented Jul 12, 2020 •

edited

Loading

ijjk commented Jul 12, 2020

ijjk commented Jul 12, 2020

ijjk commented Jul 13, 2020

ijjk commented Jul 13, 2020

Trailing slash basepath #14781

Trailing slash basepath #14781

Conversation

Janpot commented Jul 1, 2020 • edited Loading

ijjk commented Jul 1, 2020

Stats from current PR

ijjk commented Jul 2, 2020

Stats from current PR

ijjk commented Jul 2, 2020

Failing test suites

ijjk commented Jul 2, 2020

Stats from current PR

ijjk commented Jul 2, 2020

Failing test suites

ijjk commented Jul 2, 2020

Stats from current PR

ijjk commented Jul 2, 2020

Failing test suites

ijjk commented Jul 12, 2020

Stats from current PR

ijjk commented Jul 12, 2020

Stats from current PR

ijjk commented Jul 12, 2020

Stats from current PR

ijjk commented Jul 12, 2020 • edited Loading

Failing test suites

ijjk commented Jul 12, 2020 • edited Loading

Failing test suites

ijjk commented Jul 12, 2020 • edited Loading

Failing test suites

ijjk commented Jul 12, 2020

Stats from current PR

ijjk commented Jul 12, 2020

Failing test suites

ijjk commented Jul 13, 2020

Stats from current PR

ijjk commented Jul 13, 2020

Stats from current PR

Janpot commented Jul 1, 2020 •

edited

Loading

ijjk commented Jul 12, 2020 •

edited

Loading

ijjk commented Jul 12, 2020 •

edited

Loading

ijjk commented Jul 12, 2020 •

edited

Loading