Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing slash basepath #14781

Merged
merged 15 commits into from
Jul 13, 2020
Merged

Trailing slash basepath #14781

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
29b0c45
wip
Janpot Jul 1, 2020
52f67c4
revert method
Janpot Jul 1, 2020
30f575e
Add failing test
Janpot Jul 2, 2020
657ea99
Merge remote-tracking branch 'upstream/canary' into trailing-slash-ba…
Janpot Jul 2, 2020
b8db626
Same problem with other approach
Janpot Jul 2, 2020
e14328b
can just do this
Janpot Jul 2, 2020
b00b7b0
Merge remote-tracking branch 'upstream/canary' into trailing-slash-ba…
Janpot Jul 7, 2020
84b1c4e
Merge remote-tracking branch 'upstream/canary' into trailing-slash-ba…
Janpot Jul 12, 2020
27b9c95
Merge remote-tracking branch 'upstream/canary' into trailing-slash-ba…
Janpot Jul 12, 2020
a6805a1
Proper fix
Janpot Jul 12, 2020
2dff676
didn't mean to push this
Janpot Jul 12, 2020
2371966
Merge branch 'canary' into trailing-slash-basepath
Janpot Jul 12, 2020
26eae40
fix custom routes tests
Janpot Jul 12, 2020
55ffd7a
fix basepath trailing slash
Janpot Jul 13, 2020
7318783
Merge branch 'canary' into trailing-slash-basepath
kodiakhq[bot] Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
didn't mean to push this
  • Loading branch information
@Janpot
Janpot committed Jul 12, 2020
commit 2dff676e99b2f003c7f73a84d4c11ddf288b6d93
1 change: 0 additions & 1 deletion packages/next/next-server/server/next-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,6 @@ export default class Server {
false,
getCustomRouteBasePath(redirectRoute)
)

const updatedDestination = formatUrl(parsedDestination)

res.setHeader('Location', updatedDestination)
Expand Down