Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing nomodule polyfills and suggest using features only up to ES2019 for browser compatibility #15772

Merged
merged 25 commits into from
Aug 4, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
b490fde
fix: add missing ES2015 Number polyfills
kripod Aug 1, 2020
3d07324
fix: add missing ES2019 Object.fromEntries polyfill
kripod Aug 1, 2020
d256589
fix: more restrictive tsc suggestions for compat
kripod Aug 1, 2020
3242087
fix: add missing ES2015 Math polyfills
kripod Aug 1, 2020
f99747a
feat: support `export * as ns from 'module'`
kripod Aug 1, 2020
93bd1a5
feat: define `globalThis` as `window` for browsers
kripod Aug 1, 2020
653e58e
revert: "feat: define `globalThis` as `window` for browsers"
kripod Aug 1, 2020
ed22ed2
revert: "fix: add missing ES2019 Object.fromEntries polyfill"
kripod Aug 1, 2020
51112b1
fix: more restrictive tsc suggestions for compat
kripod Aug 1, 2020
f88f19e
revert: "fix: add missing ES2015 Math polyfills"
kripod Aug 1, 2020
d63e4d0
Merge branch 'canary' into fix-browser-compat
kripod Aug 1, 2020
7b61256
test: fix tsconfig snapshots
kripod Aug 1, 2020
dc4a2ab
feat: polyfill Object.fromEntries for all browsers
kripod Aug 1, 2020
e9a3b28
fix: remove a redundant prototype assignment
kripod Aug 1, 2020
11cda53
test: update bundle size limit
kripod Aug 1, 2020
15b6c43
test: update bundle size limit again
kripod Aug 1, 2020
10fad01
revert: "feat: polyfill Object.fromEntries for all browsers"
kripod Aug 1, 2020
c1b2357
fix: update tsconfig 'lib', ignoring fromEntries
kripod Aug 1, 2020
76a6902
revert: tsconfig 'lib' version restriction
kripod Aug 1, 2020
67c3162
Merge branch 'canary' into fix-browser-compat
kripod Aug 1, 2020
0ebf4df
Merge branch 'canary' into fix-browser-compat
kripod Aug 3, 2020
b39ef9a
test: add integration test for namespace exports
kripod Aug 3, 2020
788c0a0
test: try fixing Babel integration test
kripod Aug 3, 2020
98b4076
test: fix namespace-exported React
kripod Aug 3, 2020
076c027
Merge branch 'canary' into fix-browser-compat
kodiakhq[bot] Aug 4, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: update tsconfig 'lib', ignoring fromEntries
  • Loading branch information
kripod committed Aug 1, 2020
commit c1b2357b93fc62cd00ecb822bcf0dfe2cb4db18a
2 changes: 1 addition & 1 deletion packages/next/lib/typescript/writeConfigurationDefaults.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function getDesiredCompilerOptions(
suggested: [
'dom',
'dom.iterable',
'es2018', // Advance as browsers evolve, with `@next/polyfill-nomodule`
'es2019', // Advance as browsers evolve, with `@next/polyfill-nomodule`
],
},
allowJs: { suggested: true },
Expand Down
10 changes: 5 additions & 5 deletions test/integration/tsconfig-verifier/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('tsconfig.json verifier', () => {
\\"lib\\": [
\\"dom\\",
\\"dom.iterable\\",
\\"es2018\\"
\\"es2019\\"
],
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
Expand Down Expand Up @@ -74,7 +74,7 @@ describe('tsconfig.json verifier', () => {
\\"lib\\": [
\\"dom\\",
\\"dom.iterable\\",
\\"es2018\\"
\\"es2019\\"
],
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
Expand Down Expand Up @@ -141,7 +141,7 @@ describe('tsconfig.json verifier', () => {
\\"lib\\": [
\\"dom\\",
\\"dom.iterable\\",
\\"es2018\\"
\\"es2019\\"
],
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
Expand Down Expand Up @@ -189,7 +189,7 @@ describe('tsconfig.json verifier', () => {
\\"lib\\": [
\\"dom\\",
\\"dom.iterable\\",
\\"es2018\\"
\\"es2019\\"
],
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
Expand Down Expand Up @@ -234,7 +234,7 @@ describe('tsconfig.json verifier', () => {
\\"lib\\": [
\\"dom\\",
\\"dom.iterable\\",
\\"es2018\\"
\\"es2019\\"
],
\\"allowJs\\": true,
\\"skipLibCheck\\": true,
Expand Down