Update cms-kontent example to action PR feedback
#37206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommarshall
requested review from
timneutkens,
ijjk,
shuding and
styfle
as code owners
1 task
tommarshall
force-pushed
the
cms-kontent-example-image-component-tweaks
branch
from
0187d05
to
ab515dc
Compare
tommarshall
requested review from
leerob,
steven-tey and
balazsorban44
as code owners
tommarshall
force-pushed
the
cms-kontent-example-image-component-tweaks
branch
from
ab515dc
to
c7b2195
Compare
* Updates the `cms-kontent` example `Image` component to implement the suggested improvements from @styfle in vercel#37188. * Simplifies the Kontent loader host checking. * Reduces the default image quality to from `100` to `75`. * Add `tslib` dependency to fix `Module not found: Can't resolve 'tslib'` error when importing `transformImageUrl` in the `Image` component. It looks like this might be a bug in v11 of the Kontent Delivery SDK, as it appears `tslib` needs to be included as dependency, rather than dev dependency. I missed this originally as the example runs fine in the Next repo as the root `yarn.lock` has `tslib`. It's only when the example is used via `yarn create next-app` that the issue occurs. We can likely remove this in future alongside an upgrade to the SDK package once this issue has been fixed and released there. vercel#37188
tommarshall
force-pushed
the
cms-kontent-example-image-component-tweaks
branch
from
c7b2195
to
9e403f9
Compare
ijjk
approved these changes
May 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cms-kontentexampleImagecomponent to implement thesuggested improvements from @styfle in Fix
cms-kontentexampleNext/Imagedomain error #37188.100to75.tslibas a dev dependency to fixModule not found: Can't resolve 'tslib'error when importingtransformImageUrlin theImagecomponent.as it appears
tslibneeds to be included as a dependency, rather thana dev dependency.
yarn.lockhastslib. It's only when the example is used viayarn create next-appthat the issue occurs.once this issue has been fixed and released there, ref:
Module not found: Can't resolve 'tslib'when importingtransformImageUrlkontent-ai/delivery-sdk-js#347#37188
Documentation / Examples
yarn lint