Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cms-kontent example to action PR feedback #37206

Merged
merged 1 commit into from
May 26, 2022

Commits on May 26, 2022

  1. Update cms-kontent example to action PR feedback

    * Updates the `cms-kontent` example `Image` component to implement the
      suggested improvements from @styfle in vercel#37188.
    * Simplifies the Kontent loader host checking.
    * Reduces the default image quality to from `100` to `75`.
    * Add `tslib` dependency to fix `Module not found: Can't resolve 'tslib'`
      error when importing `transformImageUrl` in the `Image` component.
      It looks like this might be a bug in v11 of the Kontent Delivery SDK,
      as it appears `tslib` needs to be included as dependency, rather than
      dev dependency. I missed this originally as the example runs fine in
      the Next repo as the root `yarn.lock` has `tslib`. It's only when the
      example is used via `yarn create next-app` that the issue occurs. We
      can likely remove this in future alongside an upgrade to the SDK
      package once this issue has been fixed and released there.
    
    vercel#37188
    tommarshall committed May 26, 2022
    Configuration menu
    Copy the full SHA
    9e403f9 View commit details
    Browse the repository at this point in the history